Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Milian Wolff <milian.wolff@kdab.com>
To:     acme@redhat.com
Cc:     alexey.budankov@linux.intel.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, Milian Wolff <milian.wolff@kdab.com>
Subject: [PATCH] perf buildid-list: Initialize zstd_data
Date:   Thu, 29 Apr 2021 20:57:59 +0200
Message-Id: <20210429185759.59870-1-milian.wolff@kdab.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Fixes segmentation fault when trying to obtain buildid list (e.g. via
perf-archive) from a zstd-compressed `perf.data` file:

```
    $ perf record -z ls
    ...
    [ perf record: Captured and wrote 0,010 MB perf.data, compressed (ori=
ginal 0,001 MB, ratio is 2,190) ]
    $ memcheck perf buildid-list
    ...
    =3D=3D57268=3D=3D Invalid read of size 4
    =3D=3D57268=3D=3D    at 0x5260D88: ZSTD_decompressStream (in /usr/lib=
/libzstd.so.1.4.9)
    =3D=3D57268=3D=3D    by 0x4BB51B: zstd_decompress_stream (zstd.c:100)
    =3D=3D57268=3D=3D    by 0x425C6C: perf_session__process_compressed_ev=
ent (session.c:73)
    =3D=3D57268=3D=3D    by 0x427450: perf_session__process_user_event (s=
ession.c:1631)
    =3D=3D57268=3D=3D    by 0x42A609: reader__process_events (session.c:2=
207)
    =3D=3D57268=3D=3D    by 0x42A609: __perf_session__process_events (ses=
sion.c:2264)
    =3D=3D57268=3D=3D    by 0x42A609: perf_session__process_events (sessi=
on.c:2297)
    =3D=3D57268=3D=3D    by 0x343A62: perf_session__list_build_ids (built=
in-buildid-list.c:88)
    =3D=3D57268=3D=3D    by 0x343A62: cmd_buildid_list (builtin-buildid-l=
ist.c:120)
    =3D=3D57268=3D=3D    by 0x3C7732: run_builtin (perf.c:313)
    =3D=3D57268=3D=3D    by 0x331157: handle_internal_command (perf.c:365=
)
    =3D=3D57268=3D=3D    by 0x331157: run_argv (perf.c:409)
    =3D=3D57268=3D=3D    by 0x331157: main (perf.c:539)
    =3D=3D57268=3D=3D  Address 0x7470 is not stack'd, malloc'd or (recent=
ly) free'd
```

Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
---
 tools/perf/builtin-buildid-list.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-build=
id-list.c
index 87f5b1a4a7fa..833405c27dae 100644
--- a/tools/perf/builtin-buildid-list.c
+++ b/tools/perf/builtin-buildid-list.c
@@ -80,6 +80,9 @@ static int perf_session__list_build_ids(bool force, boo=
l with_hits)
 	if (!perf_header__has_feat(&session->header, HEADER_BUILD_ID))
 		with_hits =3D true;
=20
+	if (zstd_init(&(session->zstd_data), 0) < 0)
+		pr_warning("Decompression initialization failed. Reported data may be =
incomplete.\n");
+
 	/*
 	 * in pipe-mode, the only way to get the buildids is to parse
 	 * the record stream. Buildids are stored as RECORD_HEADER_BUILD_ID
--=20
2.31.1