Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1742226pxy; Thu, 29 Apr 2021 13:32:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykn0X8lWM48jrG4NsbOFTe4bqGLQ3sHPsPxlbOOMvL+Q+bCxPZgDUttjqrNSvxLjl8iANb X-Received: by 2002:a17:906:d110:: with SMTP id b16mr384710ejz.146.1619728338623; Thu, 29 Apr 2021 13:32:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619728338; cv=none; d=google.com; s=arc-20160816; b=ZglEEL9LyqxwvHfOPNc1pNHlAowQP/sOb/RMp11FkLfTJGyWFUTmkGuQEcGwaB477i XbP8RtNm2ioovpAoydpdD68/OXbBwutDj8gDwcGINuCuI+trGFpWgON6sgZDOHXTfvMr 1sp52FzpNDZcXY+cGg4AtSoMp8dSX3GaM4b9BUR0IGwOQFgtuY3qEMu8j/Ykg9Q16W3a DLXhxFcUNmxR2TnTo7Qtzzd85/fisosApANdqlHnx9kegiDy2rnuN2LjPEON8Ljya8k/ 34auY7GIDNW09JDL/8qjJ1ZfXb8Q6EN0sbn+NgG5pr/0CcTQUiklUKlQGFoGY9aRlK/N Ewgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=HMGFwSlM4QIc+VjRG1ux+x3/ZJo6/GXjgz0sfNr/AW8=; b=t87Jgpcihi13wjPCNE2Ekb9ihK4a2ae/sorvUPmVeuIOjKVJTO0ZkMzo1GdYkiLnLe 1F+IZBqKiE/9VdzGMKL8akhpQbTKe3PUC0gyliIWfynWhd3sFg+mhal3QO8by//AU1qE YsrsGujuCaII2Aa4zTyUVvwC84p+PnR+CBtKAt+q6FXnCdPIPqAvhmW4m71b1YNxAtiM BpTBbto4wsP/MQKb5wFX3ciHl6Obx7/u12YbBWMzM1ajUnITaVN4MS3MqCBk0DsBXCOK F3DGI/cE7VEreQZZeKgine8qYYYu5cSLWvBlKyO8G0VWOstKCzhrk47HVOhy6fn5SQph 4Jiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p5si4055147edh.472.2021.04.29.13.31.55; Thu, 29 Apr 2021 13:32:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238701AbhD2UBy convert rfc822-to-8bit (ORCPT + 99 others); Thu, 29 Apr 2021 16:01:54 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:51684 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236978AbhD2T7c (ORCPT ); Thu, 29 Apr 2021 15:59:32 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id C43DD1C0BA2; Thu, 29 Apr 2021 21:58:44 +0200 (CEST) Date: Thu, 29 Apr 2021 21:58:43 +0200 From: Pavel Machek To: Daniel Vetter Cc: Greg Kroah-Hartman , Ben Skeggs , Alex Deucher , dri-devel , intel-gfx , "Anholt, Eric" , "airlied@gmail.com" , Linux Kernel Mailing List , Aditya Pakki , Kangjie Lu , David Airlie , Linus Walleij , Jean Delvare , Laurent Pinchart Subject: Re: [PATCH 000/190] Revertion of all of the umn.edu commits Message-ID: <20210429195843.GA1067@bug> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > Revert "drm/radeon: Fix reference count leaks caused by > > pm_runtime_get_sync" > > Revert "drm/radeon: fix multiple reference count leak" > > Revert "drm/amdkfd: Fix reference count leaks." > > I didn't review these carefully, but from a quick look they all seem > rather inconsequental. Either error paths that are very unlikely, or > drivers which are very dead (looking at the entire list, not just what > you reverted here). > > Acked-by: Daniel Vetter So you are knowingly acking patch re-introducing bugs into kernel, because the bugs are minor? I don't believe that's an okay thing to do. Maybe something needs reverting, but lets not introduce bugs into kernel because they are "minor". Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html