Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Apr 2021 22:23:01 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, Kangjie Lu <kjlu@umn.edu>,
        Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 075/190] Revert "gma/gma500: fix a memory disclosure bug
 due to uninitialized bytes"
Message-ID: <20210429202301.GI31692@amd>
References: <20210421130105.1226686-1-gregkh@linuxfoundation.org>
 <20210421130105.1226686-76-gregkh@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="STPqjqpCrtky8aYs"
Content-Disposition: inline
In-Reply-To: <20210421130105.1226686-76-gregkh@linuxfoundation.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk


--STPqjqpCrtky8aYs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

>  drivers/gpu/drm/gma500/cdv_intel_display.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm=
/gma500/cdv_intel_display.c
> index 5d3302249779..f89c2088dc2d 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_display.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_display.c
> @@ -405,8 +405,6 @@ static bool cdv_intel_find_dp_pll(const struct gma_li=
mit_t *limit,
>  	struct gma_crtc *gma_crtc =3D to_gma_crtc(crtc);
>  	struct gma_clock_t clock;
> =20
> -	memset(&clock, 0, sizeof(clock));
> -
>  	switch (refclk) {
>  	case 27000:
>  		if (target < 200000) {

Original description is correct, we are returning with .vco and .dot
unitialized which is at least very very ugly, so we should keep the
memset and not revert this.

Best regards,
								Pavel
--=20
http://www.livejournal.com/~pavelmachek

--STPqjqpCrtky8aYs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAmCLFaUACgkQMOfwapXb+vIY8wCglHWfV91ODxkJrVxpHNYGcHBp
dUkAoJV/6kLn1j/p0l4KlyXYFMdBIrEK
=V7Ne
-----END PGP SIGNATURE-----

--STPqjqpCrtky8aYs--