Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1753354pxy; Thu, 29 Apr 2021 13:50:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynkwT6ot0kGtrWZyJqsJJ7yWAwnsrG3oVu7enmhCkTxywnqk5TuRuLGY7ytbuzgWBkvDol X-Received: by 2002:a63:fc10:: with SMTP id j16mr1547612pgi.152.1619729407468; Thu, 29 Apr 2021 13:50:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619729407; cv=none; d=google.com; s=arc-20160816; b=GkN1xXMXUGdMiuUFrTJ51MEvf69oXvP7u069MSKKg91fx/XES3+vxof4iaX/1yYGY5 KLIElvWik6jWK5549Kf36YFaah67USXajZVkvhX835JKXe2Xdbcs1Ypo7iolFRHsgHjU /OPadlzBl0mcvb8CuBtU9B+KJJP7USmD84in9n6AWUHbIiTKLYWMRCzSNPRxjdv7KMoU h+ZEpYzKPk+/GIeqI5J34A8n+aQXRbEqbvsWqm3qZNAaHW+qB5N0VtVTrs8Ij7whd1Rg Dza2CUoobldVuCtl567riSuVp4+/AEMNo5Z5hbwv2QFo98rznWjMti7FGJXV3pcpHpPi OidA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pWM5Xu7wIYzZp7eGSboEhbdiiLmMWtTkOWFVFd4JcnA=; b=EdR3152SM8xf+KqSfqVlDGKzpBmjlonFkGLR+ffuddV4v++EtLt13xqf1MKXeVBvNs TDziXoNXJzwWmr9AoVBwWBL+Xida7FmwBjNHsFcs4shBw0/aZLWiLXTZXrBhpCFe+Br8 YGZ9VcujtFwmt+4mIqN5Rg29/GbF7ivqN5rCzL3USBSVv9H//HxeoQYIgqmuLVMuihfD 1gjnHW5hzEGrWYZLiaTop3Ys9peIy2p/0BqkgyhmeWCIJe8Tkl1QvvijZzWI7+mHv59Z G7g9v2oDYIqV7qbLuyRzg3odni9r2QRykkTU98H58DD5n6by6igSZKgguuIPOCamV8Lp KHBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=hLFx5PLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c24si1325587pgj.407.2021.04.29.13.49.53; Thu, 29 Apr 2021 13:50:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=hLFx5PLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237145AbhD2Uip (ORCPT + 99 others); Thu, 29 Apr 2021 16:38:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237127AbhD2Uio (ORCPT ); Thu, 29 Apr 2021 16:38:44 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 135E3C06138C; Thu, 29 Apr 2021 13:37:56 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id q9so14078413wrs.6; Thu, 29 Apr 2021 13:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pWM5Xu7wIYzZp7eGSboEhbdiiLmMWtTkOWFVFd4JcnA=; b=hLFx5PLWQIR3xKQ/5IvKVagswkOhcm/GYU8c3GAMQo/ARWnheC5evOm0VRegdVMQdj lPVmQRHkXHfAaD24FiV3svwy5Uu7udU0IgFQjrDFeZSDxpfIa/119r4zjJf/SlQXDSfE amaHQw4lU5hruHI5Aea41azqdX411FSF2RNw1Ihf+x1pPT7NHbA+OFOtFh4wpfDoU2yk T7tFv0ATcuhV7ZuFOy9WiW6Q7oMKHxD8xQXxOZ43njQuUjudVul3ranRu9e9N2+K3/R5 dyjpFKpVyojtPLDAqB2tGDJyNk20yjdbekRxPUokFE9YsRSIEhQVSflEby+8OqkUf8zP EB+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pWM5Xu7wIYzZp7eGSboEhbdiiLmMWtTkOWFVFd4JcnA=; b=M9+Rzr/lghRfPTR0OZzRvncJkR0gSCIT+b+zYBn1gTCi1/5Sh6rOAmr3A5G0cxhb3A LXr7BPJghSawLdGQb6TAkSf2hrFS9uYEhrUtxMW7mNJP5tIlwINxmZd3GRtt6K+BWqut zSwYpn+bv7H6INyTdsP+V858enRIQP3FTkD8doFjpcJzGAxNZOb3eZkJ90K0JRtP/U76 LAPW7Pf1DaVN4uzbOJo9Ig6RBNWhr13wVeb/62n7/thQYmXkIp3ND+0L4a4xulyBxEee KsJ8rbQNWUW1ysxEtySZDOVE5WhpdX6vOGx3/hJDpP52bEst7eoT8JmaUoZIaIAtnFXH qA/w== X-Gm-Message-State: AOAM530rr/r35VHiXtg24UJv1PA/lWgY0rzTgysQPLIqjM2Gt7bZ2lb/ Ymd9uYoplQhMQWc5wR7Whkw= X-Received: by 2002:adf:e8c4:: with SMTP id k4mr1841574wrn.262.1619728674667; Thu, 29 Apr 2021 13:37:54 -0700 (PDT) Received: from localhost.localdomain (p200300f137153600428d5cfffeb99db8.dip0.t-ipconnect.de. [2003:f1:3715:3600:428d:5cff:feb9:9db8]) by smtp.googlemail.com with ESMTPSA id x25sm11635783wmj.34.2021.04.29.13.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Apr 2021 13:37:53 -0700 (PDT) From: Martin Blumenstingl To: narmstrong@baylibre.com, khilman@baylibre.com, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Martin Blumenstingl , Stefan Agner Subject: [PATCH RFC] soc: amlogic: meson-ee-pwrc: Drop the .shutdown callback from the driver Date: Thu, 29 Apr 2021 22:37:23 +0200 Message-Id: <20210429203723.1177082-1-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stefan reports that rebooting his ODROID-N2+ (using a G12B SoC) results in the board hanging. His kernel config uses: CONFIG_MESON_EE_PM_DOMAINS=y CONFIG_DRM_MESON=m He reports that his kernel config results in the DRM driver's .shutdown callback to be executed after the power domain driver's .shutdown callback. That's problematic because meson_ee_pwrc_shutdown disables the clock which are used by the VPU IP. This causes the board to hang. Further he reports that changing from CONFIG_DRM_MESON=m to CONFIG_DRM_MESON=y reverses the order in which the DRM and power domain driver's shutdown functions are executed, making the reboot successful. The reason why we use meson_ee_pwrc_shutdown is because of the VPU power domain (which is causing the problem described above). It can be left enabled by u-boot. According to the original TOFIX comment in meson_ee_pwrc_init_domain we need to be careful because disabling the power domain could "cause system errors". As a workaround the clocks are manually enabled in meson_ee_pwrc_init_domain and the power domain is marked as GENPD_FLAG_ALWAYS_ON (so it can never be turned off). Experimenting has shown that the power domain itself can be disabled as long as we keep the clocks enabled if u-boot enabled the power domain but we don't have any driver enabled for the VPU (CONFIG_DRM_MESON=n). Keeping the clocks enabled is the responsibility of the CCF drivers, not the power domain driver. Even better: this is already covered as all gates in the VPU and VAPB tree on GX an G12 SoCs have the CLK_IGNORE_UNUSED flag set, meaning: if the bootloader has previously enabled the clock we're not touching it until a driver explicitly asks to enable (and then disable) it. In case of CONFIG_DRM_MESON=n we're never calling meson_ee_pwrc_on, meaning that we always keep the state of the clocks as set by u-boot. The original TOFIX comment also mentioned that we need to make sure not to mess up the clock's prepare/enable ref-counters. This is the only requirement that's left for the meson-ee-pwrc driver that needs to be managed for the VPU power domain. Three steps can improve this situation: - Don't prepare and enable the clocks (just to fix the ref-counting) in meson_ee_pwrc_init_domain if u-boot left that power domain enabled. Instead, remember if the clocks are enabled in meson_ee_pwrc_{on,off} and only disable them if we have previously turned them on ourselves. - Drop GENPD_FLAG_ALWAYS_ON as we can always manage the state of the VPU power domain if both the power domain controller and DRM driver are enabled (=m or =y). If the power domain driver is enabled but the DRM driver is disabled we can still use meson_ee_pwrc_off because it's not trying to disable the clocks anymore - Drop meson_ee_pwrc_shutdown as it's the responsibility of the genpd framework to call meson_ee_pwrc_off when needed (either when a power domain is being disabled - regardless of whether it's was used by a driver before or not). Now there's also no more shutdown callback ordering dependency between the power domain driver and other drivers anymore. Fixes: eef3c2ba0a42a6 ("soc: amlogic: Add support for Everything-Else power domains controller") Reported-by: Stefan Agner Signed-off-by: Martin Blumenstingl --- Neil, I would like you to specifically review (and re-test) the original TOFIX part. I *believe* that I understand the original problem and hope that my approach also works in that scenario, but I am not 100% sure. Kevin, as you're my go-to genpd expert I am also asking you to review this to point out any issues you see. drivers/soc/amlogic/meson-ee-pwrc.c | 76 ++++++++++++----------------- 1 file changed, 31 insertions(+), 45 deletions(-) diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c index 50bf5d2b828b..534c33ba31ce 100644 --- a/drivers/soc/amlogic/meson-ee-pwrc.c +++ b/drivers/soc/amlogic/meson-ee-pwrc.c @@ -353,10 +353,26 @@ static int meson_ee_pwrc_off(struct generic_pm_domain *domain) if (pwrc_domain->num_clks) { msleep(20); - clk_bulk_disable_unprepare(pwrc_domain->num_clks, - pwrc_domain->clks); + + /* + * We are only allowed to turn off the clocks here if we + * have previously enabled them ourselves. In other words: + * for an "unused" power domain (which is not used by any + * power domain consumer) we have not enabled the clocks + * previously so we keep them in the state they are. + * This is relevant for the VPU power domain which may + * have been enabled by u-boot. If the display driver in + * Linux is disabled then we need to keep the clocks in + * the state as u-boot set them, otherwise the board will + * hang. + */ + if (pwrc_domain->enabled) + clk_bulk_disable_unprepare(pwrc_domain->num_clks, + pwrc_domain->clks); } + pwrc_domain->enabled = false; + return 0; } @@ -392,8 +408,14 @@ static int meson_ee_pwrc_on(struct generic_pm_domain *domain) if (ret) return ret; - return clk_bulk_prepare_enable(pwrc_domain->num_clks, - pwrc_domain->clks); + ret = clk_bulk_prepare_enable(pwrc_domain->num_clks, + pwrc_domain->clks); + if (ret) + return ret; + + pwrc_domain->enabled = true; + + return 0; } static int meson_ee_pwrc_init_domain(struct platform_device *pdev, @@ -434,33 +456,11 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev, dom->base.power_on = meson_ee_pwrc_on; dom->base.power_off = meson_ee_pwrc_off; - /* - * TOFIX: This is a special case for the VPU power domain, which can - * be enabled previously by the bootloader. In this case the VPU - * pipeline may be functional but no driver maybe never attach - * to this power domain, and if the domain is disabled it could - * cause system errors. This is why the pm_domain_always_on_gov - * is used here. - * For the same reason, the clocks should be enabled in case - * we need to power the domain off, otherwise the internal clocks - * prepare/enable counters won't be in sync. - */ - if (dom->num_clks && dom->desc.get_power && !dom->desc.get_power(dom)) { - ret = clk_bulk_prepare_enable(dom->num_clks, dom->clks); - if (ret) - return ret; - - dom->base.flags = GENPD_FLAG_ALWAYS_ON; - ret = pm_genpd_init(&dom->base, NULL, false); - if (ret) - return ret; - } else { - ret = pm_genpd_init(&dom->base, NULL, - (dom->desc.get_power ? - dom->desc.get_power(dom) : true)); - if (ret) - return ret; - } + ret = pm_genpd_init(&dom->base, NULL, + (dom->desc.get_power ? + dom->desc.get_power(dom) : true)); + if (ret) + return ret; return 0; } @@ -528,19 +528,6 @@ static int meson_ee_pwrc_probe(struct platform_device *pdev) return of_genpd_add_provider_onecell(pdev->dev.of_node, &pwrc->xlate); } -static void meson_ee_pwrc_shutdown(struct platform_device *pdev) -{ - struct meson_ee_pwrc *pwrc = platform_get_drvdata(pdev); - int i; - - for (i = 0 ; i < pwrc->xlate.num_domains ; ++i) { - struct meson_ee_pwrc_domain *dom = &pwrc->domains[i]; - - if (dom->desc.get_power && !dom->desc.get_power(dom)) - meson_ee_pwrc_off(&dom->base); - } -} - static struct meson_ee_pwrc_domain_data meson_ee_g12a_pwrc_data = { .count = ARRAY_SIZE(g12a_pwrc_domains), .domains = g12a_pwrc_domains, @@ -606,7 +593,6 @@ MODULE_DEVICE_TABLE(of, meson_ee_pwrc_match_table); static struct platform_driver meson_ee_pwrc_driver = { .probe = meson_ee_pwrc_probe, - .shutdown = meson_ee_pwrc_shutdown, .driver = { .name = "meson_ee_pwrc", .of_match_table = meson_ee_pwrc_match_table, -- 2.31.1