Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1783592pxy; Thu, 29 Apr 2021 14:40:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9c4rV9fKpm2DOYWG6ridDHuPPmCwrE8DQuK34Suu5mud9uTaap2mVLatQdKlKnwGW7RsA X-Received: by 2002:a17:906:704a:: with SMTP id r10mr629019ejj.312.1619732403784; Thu, 29 Apr 2021 14:40:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619732403; cv=none; d=google.com; s=arc-20160816; b=i0tSzeFlxX44N0JCuNIR7DPffjaXhZP01wCUwtdi006nrVF3ApubHF8jRfBpWKSYkx SUeRb43H4DnIAVAkMIBY6s6jqccr8B5kNhVZslVNUmXvUqk1ieGzLP2Bp3AzH799ZEBX 8qRA7zDB32Y+B0uvVzv43Z65sAlQOWa4wEDGbSl5OPS6i2rCfRIMH/HySeLoUd7n9pzh xU2+cuvl+p0eHJ4+gLfjA2XAcow1hAIrCaOb5q8+BvEKlQqSxyOgXOQxDAEbSmAFaCkx sRQVFoQMy7M5XWMAnYHaN6Hd1kp2afCHE3CenJPy1sEjo1AJdUnEujXvBXhYpvAl3Btl jF4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=6oQXr7Ax60LhzRD1OI6DzqVpflT7v5GsOq4b1l5OxG4=; b=xhlWQtq6i9TpyHU5AzBcprJWzDbhOfzrKpGGCB3xckIsH8PVA+nmUxXiVRGVnQPFhu tx5EU5+6URBsj5SPdc+QfcIRI8H+4rcyjNtDgWlG5mo+BQ2cDtt1yTV4QnYaVhMxBzNx fN1LHi7Hxo2UUG1da9kSumNK+wS39Wumajy9o6TTcQuVV9gq6MWJAW2eMG8Eb9fUoQgn 7vALG3cG1+nB1XDRnLOz9coOsvmh6PxwFpu7s16N+yCrFVCLBmlVmaI5YW/rBzIpKux6 2bZIUdjao0FDtVGVuwxV5SV9JBffk43hUgwS6meFyxwF9ZK2fhuydFtCf0uSb16FpQET bFsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si995238ejj.34.2021.04.29.14.39.40; Thu, 29 Apr 2021 14:40:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237418AbhD2Vje (ORCPT + 99 others); Thu, 29 Apr 2021 17:39:34 -0400 Received: from mga01.intel.com ([192.55.52.88]:10691 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237032AbhD2Vjc (ORCPT ); Thu, 29 Apr 2021 17:39:32 -0400 IronPort-SDR: AyMcRTztoBUC77IhADgAt0LhUbceF3AHu947TtV0/ADXiF/kAmnnV+3ZztzmUqP7kJqcTvgd7U D1HOC4e8maTg== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="217861329" X-IronPort-AV: E=Sophos;i="5.82,260,1613462400"; d="scan'208";a="217861329" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 14:38:40 -0700 IronPort-SDR: f9Nh7tLxPyeV16MID3qgW3/z74cOv1GJzhZX5F4vJlQFhkjebjEJk4FA5aP6Aidt/L8DGuhrI8 1nO0jEUGYTeg== X-IronPort-AV: E=Sophos;i="5.82,260,1613462400"; d="scan'208";a="387102569" Received: from ndutta-mobl.amr.corp.intel.com (HELO [10.212.215.226]) ([10.212.215.226]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 14:38:39 -0700 Subject: Re: [PATCH 1/2] CPU, NUMA topology ABIs: clarify the overflow issue of sysfs pagebuf To: "Song Bao Hua (Barry Song)" , "tiantao (H)" , "corbet@lwn.net" , "gregkh@linuxfoundation.org" Cc: "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" , Peter Zijlstra , Valentin Schneider , Dave Hansen , Daniel Bristot de Oliveira References: <1619679819-45256-1-git-send-email-tiantao6@hisilicon.com> <1619679819-45256-2-git-send-email-tiantao6@hisilicon.com> <146e051b-603c-a6d3-43d8-d083cf2c8119@intel.com> <602918a1e2214ea7bd0890a751975566@hisilicon.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <7c663f7e-07e0-6d95-3012-6e31a1b78f7e@intel.com> Date: Thu, 29 Apr 2021 14:38:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <602918a1e2214ea7bd0890a751975566@hisilicon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/29/21 2:08 PM, Song Bao Hua (Barry Song) wrote: >> Do we think >PAGE_SIZE data out of a sysfs file is a worse ABI break or >> something? > This kind of cpu list ABIs have been there for many years but have > never been documented well. > > We have two ABIs: > xxx_cpus - in format like 3333333333 > xxx_cpus_list - in format like 0,3,5,7,9,11,13.... > > xxx_cpus_list is another human-readable version of xxx_cpus. It doesn't > include any more useful information than xxx_cpus. > > xxx_cpus won't overflow based on BUILD_BUG_ON and maximum NR_CPUS > in kconfig nowadays. > > if people all agree the trimmed list is a break of ABI, I think we may > totally remove this list. For these days, this list probably has never > overflowed but literally this could happen. > > thoughts? From what Greg said, it sounds like removing the BUILD_BUG_ON(), making it a binary sysfs file, and making it support arbitrary lengths is the way to go.