Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: A+siUOGVQpbMjKglJ/t4NVdS5/Si9in+hmBCwLo7PSROHmXF/TzbCg5Is85L7rG+4eglrb4l9u
 FiCWQTEIadTA==
IronPort-SDR: wUIRniA64jIADyg/rCjhKBZNXOM9hjBMqSwKkbQa6qoj0/E19wn6V0fgjmHAQtweLmaNMtvg44
 TgWTXR1cRBxQ==
Subject: Re: [PATCH 11/12] perf intel-pt: Add VM Time Correlation to decoder
To:     Andi Kleen <ak@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
References: <20210429125854.13905-1-adrian.hunter@intel.com>
 <20210429125854.13905-12-adrian.hunter@intel.com>
 <20210429212140.GE4032392@tassilo.jf.intel.com>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <4f9b20f7-566b-9e32-e9b9-bf6d11ef5d9f@intel.com>
Date:   Fri, 30 Apr 2021 08:02:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <20210429212140.GE4032392@tassilo.jf.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 30/04/21 12:21 am, Andi Kleen wrote:
>> unchanging (during perf record) VMX TSC Offset and no VMX TSC scaling.
> 
> For TSC scaling we would need to add side band to KVM, correct?
> 
> I suppose it shouldn't be that hard to do that.
> 

Probably we just need to know a single TSC scaling value per VM i.e. it could just be exported via sysfs or something.

There is a reasonable reason that TSC Offset might be changing i.e. to match Guest time, although that seems to be done by paravirtualization instead at the moment.
At the moment TSC Offset does change if Host time changes e.g. Guest has state saved before a Host reboot, and is resumed after the Host reboot

However, I can't think of a reason for changing the TSC Scaling value, except maybe if the VM is taken to a Host with a different TSC frequency.