Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Guoqing Jiang <gqjiang@suse.com>,
        Aditya Pakki <pakki001@umn.edu>
Subject: Re: [PATCH 134/190] Revert "md: Fix failed allocation of
 md_register_thread"
Thread-Topic: [PATCH 134/190] Revert "md: Fix failed allocation of
 md_register_thread"
Thread-Index: AQHXNq9BJ7/u/5Jha0OLmyLLbbYM+6rJdjEAgAMrdAA=
Date:   Fri, 30 Apr 2021 06:10:24 +0000
Message-ID: <14DC41E8-99F5-491A-93EF-598D10E381FE@fb.com>
References: <20210421130105.1226686-1-gregkh@linuxfoundation.org>
 <20210421130105.1226686-135-gregkh@linuxfoundation.org>
 <YIj2nsovH/+ujHL0@kroah.com>
In-Reply-To: <YIj2nsovH/+ujHL0@kroah.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B5228A78659F804B865470F3376B071C@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 81010c5b-7f1d-446a-4655-08d90b9ea519
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2021 06:10:24.8653
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FqMHlJVXZB1hRfgWo6naloh4MOnwF/AHAVW0nFXGZQ5A+i+5m9Zzc7VFp84fUxsT/GfEt5otC0j/2dddXOO5AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR15MB4977
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: Ul5_-stOT5qnTnmtPJ7t_mfbqqmXkTqs
X-Proofpoint-GUID: Ul5_-stOT5qnTnmtPJ7t_mfbqqmXkTqs
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-04-30_03:2021-04-28,2021-04-30 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 malwarescore=0
 priorityscore=1501 suspectscore=0 clxscore=1011 spamscore=0 bulkscore=0
 lowpriorityscore=0 phishscore=0 adultscore=0 mlxlogscore=999
 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104300044
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 27, 2021, at 10:46 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.=
org> wrote:
>=20
> On Wed, Apr 21, 2021 at 03:00:09PM +0200, Greg Kroah-Hartman wrote:
>> This reverts commit e406f12dde1a8375d77ea02d91f313fb1a9c6aec.
>>=20
>> Commits from @umn.edu addresses have been found to be submitted in "bad
>> faith" to try to test the kernel community's ability to review "known
>> malicious" changes.  The result of these submissions can be found in a
>> paper published at the 42nd IEEE Symposium on Security and Privacy
>> entitled, "Open Source Insecurity: Stealthily Introducing
>> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
>> of Minnesota) and Kangjie Lu (University of Minnesota).
>>=20
>> Because of this, all submissions from this group must be reverted from
>> the kernel tree and will need to be re-reviewed again to determine if
>> they actually are a valid fix.  Until that work is complete, remove this
>> change to ensure that no problems are being introduced into the
>> codebase.
>>=20
>> Cc: stable@vger.kernel.org # v3.16+
>> Cc: Guoqing Jiang <gqjiang@suse.com>
>> Cc: Aditya Pakki <pakki001@umn.edu>
>> Cc: Song Liu <songliubraving@fb.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
>> drivers/md/raid10.c | 2 --
>> drivers/md/raid5.c  | 2 --
>> 2 files changed, 4 deletions(-)
>>=20
>> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
>> index a9ae7d113492..4fec1cdd4207 100644
>> --- a/drivers/md/raid10.c
>> +++ b/drivers/md/raid10.c
>> @@ -3896,8 +3896,6 @@ static int raid10_run(struct mddev *mddev)
>> 		set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
>> 		mddev->sync_thread =3D md_register_thread(md_do_sync, mddev,
>> 							"reshape");
>> -		if (!mddev->sync_thread)
>> -			goto out_free_conf;
>> 	}
>>=20
>> 	return 0;
>> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
>> index 5d57a5bd171f..9b2bd50beee7 100644
>> --- a/drivers/md/raid5.c
>> +++ b/drivers/md/raid5.c
>> @@ -7677,8 +7677,6 @@ static int raid5_run(struct mddev *mddev)
>> 		set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
>> 		mddev->sync_thread =3D md_register_thread(md_do_sync, mddev,
>> 							"reshape");
>> -		if (!mddev->sync_thread)
>> -			goto abort;
>> 	}
>>=20
>> 	/* Ok, everything is just fine now */
>> --=20
>> 2.31.1
>>=20
>=20
> These changes look ok, but the error handling logic seems to be freeing
> the incorrect thread, not the one that these functions create.  That's
> independant of this change, but seems odd.  If someone cares about it,
> it should probably be looked at, or if correct, a comment would be nice
> as it's really confusing.

I don't think this is confusing. raid[5|10]_run() creates two threads:
first mddev->thread, then mddev->sync_thread. If we fail to create the
second thread (sync_thread), we free the first thread (mddev->thread) in=20
the error handling logic.=20

Thanks,
Song