Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <3c5dde7cd24cf10707b682cce0cac74e5ac37e9b.camel@gmail.com>
Subject: Re: [PATCH] scsi: ufs: remove redundant initialization of variable
From:   Bean Huo <huobean@gmail.com>
To:     keosung.park@samsung.com, ALIM AKHTAR <alim.akhtar@samsung.com>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     Daejun Park <daejun7.park@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>
Date:   Fri, 30 Apr 2021 10:47:46 +0200
In-Reply-To: <2038148563.21619749381770.JavaMail.epsvc@epcpadp4>
References: <CGME20210430021419epcms2p402717e968615d301ba18341d28a828ee@epcms2p4>
         <2038148563.21619749381770.JavaMail.epsvc@epcpadp4>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2021-04-30 at 11:14 +0900, Keoseong Park wrote:
> The variable d_lu_wb_buf_alloc may be repeatedly initialized to 0 in
> a for-loop.
> 
> If the variable is set to a value other than 0, it exits the for-
> loop, so there is no need to reset it to 0.
> 
> 
> 
> Since lun and d_lu_wb_buf_alloc are just being used in a else
> statement inside a local scope, move the declaration of the variables
> to that scope.
> 
> 
> 
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>

UFS Spec 3.1, bDeviceMaxWriteBoosterLUs is 01h, for LU dedicated buffer
mode, WriteBooster Buffer can be configured in only one logical unit.

Bean