Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp130759pxy; Fri, 30 Apr 2021 01:52:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiJWDYADpwpVCUTFOtjwhB5wduyauMEaF5fPtpVitROmaEFUHzDzh/ZRVQ9MSs/1IvtZl0 X-Received: by 2002:a17:902:7c8a:b029:e6:f010:a4f4 with SMTP id y10-20020a1709027c8ab02900e6f010a4f4mr4250281pll.17.1619772760246; Fri, 30 Apr 2021 01:52:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619772760; cv=none; d=google.com; s=arc-20160816; b=Tm65U0MsIc79Qsj044jPkn3uUfO7TIrwJXZ9+znw/633WikaILYrZeRtBzJ2elint+ zBQyxdm2dsREzaQ3mtpJzDCISKBzIpLyZU30hE/729n+nYD7OCn0O3Ltf5JmuhVvWxX/ YCgdEqKqECN7iV5jSUovqrZwDRNWeecSdxvrVndN5T/kqd+t1vta7NaPfcApihPViMvw 3UgMM9xAinvzNB80bqHwXcX07gDNkq9TX8+TOMVuZ84KkOl5Xn6NLQn26CwAgXyTZP6F 3HVfiUQMHNoCGwKbFt0tlFz+qvrXNBzjK3QARpC6ShE7Wh7ir3sW6JP1uJn7LLEWaFVK WUow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=snCjk8Gq8I6wDY/F/WBUrHU8qjCqwzPxo6jAtkokcOQ=; b=yXy/NkzeMjzU2g+H32L3QX7Le14OwmGnjbdpAkLUmibK+NbLE/SRuz19hQYZX55Tdo jHkzZCTdHcp6DpLv7d03U8UWlgiOE8R+DxVqMkOroP9vp7bw6AFF2eBtAyU3uh4UYZHj XeIMHPYS8ZnOQcH1F3Z5ptHhNLv3M8FMkeLJPAPNz1UJxGw/sXocmgtBYYsLekaaOo/3 iloiBOhqrb3amq7n/8t9mHKLk1mtZplrSAVc3Xilb21zTWu4gVoNMlrljbrohuyVYGwl JiWkrEUhQjWBSHxBKCG7MUX1SBc5M6wd9+2++Ta9kWbtE028X7IqCSaJtX64U5gd/2o8 0t3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 89si1291407plb.254.2021.04.30.01.52.27; Fri, 30 Apr 2021 01:52:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbhD3Iwf (ORCPT + 99 others); Fri, 30 Apr 2021 04:52:35 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:64434 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbhD3Iwf (ORCPT ); Fri, 30 Apr 2021 04:52:35 -0400 Received: from localhost (mailhub3.si.c-s.fr [192.168.12.233]) by localhost (Postfix) with ESMTP id 4FWmM65lWcz9wpv; Fri, 30 Apr 2021 10:51:46 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kDMDiR5czLYa; Fri, 30 Apr 2021 10:51:46 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FWmM64dTtz9wkP; Fri, 30 Apr 2021 10:51:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 8E0978B87A; Fri, 30 Apr 2021 10:51:46 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id ILHb2NrNnZ0M; Fri, 30 Apr 2021 10:51:46 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B86C08B876; Fri, 30 Apr 2021 10:51:45 +0200 (CEST) Subject: Re: [PATCH 2/3] powerpc: prom_init: switch to early string functions To: Daniel Walker , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, Andrew Morton Cc: xe-linux-external@cisco.com, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linux-kernel@vger.kernel.org References: <20210430042217.1198052-1-danielwa@cisco.com> <20210430042217.1198052-2-danielwa@cisco.com> From: Christophe Leroy Message-ID: Date: Fri, 30 Apr 2021 10:51:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210430042217.1198052-2-danielwa@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 30/04/2021 à 06:22, Daniel Walker a écrit : > This converts the prom_init string users to the early string function > which don't suffer from KASAN or any other debugging enabled. > > Cc: xe-linux-external@cisco.com > Signed-off-by: Daniel Walker > --- > arch/powerpc/kernel/prom_init.c | 185 ++++++------------------- > arch/powerpc/kernel/prom_init_check.sh | 9 +- > 2 files changed, 51 insertions(+), 143 deletions(-) > > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c > index ccf77b985c8f..4d4343da1280 100644 > --- a/arch/powerpc/kernel/prom_init.c > +++ b/arch/powerpc/kernel/prom_init.c > @@ -225,105 +225,6 @@ static bool __prombss rtas_has_query_cpu_stopped; > #define PHANDLE_VALID(p) ((p) != 0 && (p) != PROM_ERROR) > #define IHANDLE_VALID(i) ((i) != 0 && (i) != PROM_ERROR) > > -/* Copied from lib/string.c and lib/kstrtox.c */ Please leave the second part of the comment as you have not removed prom_strtobool()