Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 30 Apr 2021 11:12:30 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Kevin Tang <kevin3.tang@gmail.com>
Cc:     maarten.lankhorst@linux.intel.com, sean@poorly.run,
        airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org,
        mark.rutland@arm.com, orsonzhai@gmail.com, zhang.lyra@gmail.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/6] dt-bindings: display: add Unisoc's drm master
 bindings
Message-ID: <20210430091230.5gf3jzhd7hjmxjnq@gilmour>
References: <20210425123607.26537-1-kevin3.tang@gmail.com>
 <20210425123607.26537-2-kevin3.tang@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ckdz3meppmjafuxn"
Content-Disposition: inline
In-Reply-To: <20210425123607.26537-2-kevin3.tang@gmail.com>
Precedence: bulk


--ckdz3meppmjafuxn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 25, 2021 at 08:36:02PM +0800, Kevin Tang wrote:
> From: Kevin Tang <kevin.tang@unisoc.com>
>=20
> The Unisoc DRM master device is a virtual device needed to list all
> DPU devices or other display interface nodes that comprise the
> graphics subsystem
>=20
> Unisoc's display pipeline have several components as below
> description, multi display controllers and corresponding physical
> interfaces.
> For different display scenarios, dpu0 and dpu1 maybe binding to
> different encoder.
>=20
> E.g:
>   dpu0 and dpu1 both binding to DSI for dual mipi-dsi display;
>   dpu0 binding to DSI for primary display, and dpu1 binding to DP for
>   external display;
>=20
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  .../display/sprd/sprd,display-subsystem.yaml  | 64 +++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,d=
isplay-subsystem.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,display-=
subsystem.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,displa=
y-subsystem.yaml
> new file mode 100644
> index 000000000..3d107e943
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsyst=
em.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/sprd/sprd,display-subsystem.y=
aml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc DRM master device
> +
> +maintainers:
> +  - Kevin Tang <kevin.tang@unisoc.com>
> +
> +description: |
> +  The Unisoc DRM master device is a virtual device needed to list all
> +  DPU devices or other display interface nodes that comprise the
> +  graphics subsystem.
> +
> +  Unisoc's display pipeline have several components as below description,
> +  multi display controllers and corresponding physical interfaces.
> +  For different display scenarios, dpu0 and dpu1 maybe binding to differ=
ent
> +  encoder.
> +
> +  E.g:
> +  dpu0 and dpu1 both binding to DSI for dual mipi-dsi display;
> +  dpu0 binding to DSI for primary display, and dpu1 binding to DP for ex=
ternal display;
> +
> +          +-----------------------------------------+
> +          |                                         |
> +          |                            +---------+  |
> +  +----+  |   +----+    +---------+    |DPHY/CPHY|  |   +------+
> +  |    +----->+dpu0+--->+MIPI|DSI +--->+Combo    +----->+Panel0|
> +  |AXI |  |   +----+    +---------+    +---------+  |   +------+
> +  |    |  |                  ^                      |
> +  |    |  |                  |                      |
> +  |    |  |      +-----------+                      |
> +  |    |  |      |                                  |
> +  |APB |  |   +--+-+    +-----------+    +---+      |   +------+
> +  |    +----->+dpu1+--->+DisplayPort+--->+PHY+--------->+Panel1|
> +  |    |  |   +----+    +-----------+    +---+      |   +------+
> +  +----+  |                                         |
> +          +-----------------------------------------+
> +
> +properties:
> +  compatible:
> +    const: sprd,display-subsystem
> +
> +  ports:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description:
> +      Should contain a list of phandles pointing to display interface po=
rt
> +      of DPU devices.
> +
> +required:
> +  - compatible
> +  - ports
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    display-subsystem {
> +        compatible =3D "sprd,display-subsystem";
> +        ports =3D <&dpu_out>;
> +    };

Given your diagram, I guess it should be the dpu input?

Maxime

--ckdz3meppmjafuxn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYIvJ/gAKCRDj7w1vZxhR
xTq6AQCqZKEHkztnHiklozfzjR7wJ4k41aVx8gMmXSmNJExpHwD/b88xdl0VmOY9
M8CsGWdBFk3WsY4AoPfSrFwxwgFr5Qc=
=G+SR
-----END PGP SIGNATURE-----

--ckdz3meppmjafuxn--