Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp169103pxy; Fri, 30 Apr 2021 02:55:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQh3E4CHdc3Hfuey+71isK9K26HdsD/Z1LYp4xi9UWkY3x05VId92ejR4z0IHTg9IhfcT9 X-Received: by 2002:a17:90a:6303:: with SMTP id e3mr5833043pjj.225.1619776510123; Fri, 30 Apr 2021 02:55:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619776510; cv=none; d=google.com; s=arc-20160816; b=wgVlxK6Cps8fcKU2cIN2AFT1RUDY9voM5KbkcQRAwOQX/h6Yc0igxf0WBeaV/a0XVy DF/N/fBg8Kf8umL5sIrgpEb7SJfAGYZZ5Ybm2rbUZacWbenUTYF3tMyMYuzQoWSgVRgK Gz41aoeYwaogwjBm1rMgEqX20ZJ+eVkgWZkeoHMOgo2cGf7ZXr9/5ikcTIzPdEcrOY2A V8r1rhZXqQBk/Gr19765bWGiF8by+YGtjdQWrNwfAa7hTPb2OCcHmlRypGd3VW0fURwz afWjnrKZMS8S+LAlM+3Sumr7bZR1Z4ruNXVI1TY/WYmhVfE1ERdJC1fIHRSc1mzues4U 8YbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=d8rYa6uc2lMrcOYnMsUxtzNfzc4dHA6oZT2T6vUtpxM=; b=O6KD28/FHkjtypMdpRhte96GY5Jqc4UCoenz4MoFgj08JrCnBpjLb8CLik6gsJoT91 b/DzoXhxJMrUWDkBAYnQjH7/gt10UmMqvRCYONaFA+Ev5dgUvDC3YrJOxZp33wakHrRX dxy+wzpVhVWVVx3R6h1phu9JoBUxT0gdwfOwA+PUFWdXjYE5zMQyBaRYXii8eK1EnPfQ SNpYfps6AbBlBrCSuNSlGwupaw49qj205qsDkp+jWbyp37JjXvW/BXtFbgH1ceep4Tev i21T+14h8M5DdVumSKzfCMVm6N6sizkqn0WdgXMRM1FfOyWyPmedsvWQZDp9vy+YYBve 9AKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JYCxRRsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u6si2387316plg.366.2021.04.30.02.54.56; Fri, 30 Apr 2021 02:55:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JYCxRRsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231691AbhD3JyT (ORCPT + 99 others); Fri, 30 Apr 2021 05:54:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231559AbhD3JyS (ORCPT ); Fri, 30 Apr 2021 05:54:18 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 294DAC06138B for ; Fri, 30 Apr 2021 02:53:30 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id d14so18099584edc.12 for ; Fri, 30 Apr 2021 02:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d8rYa6uc2lMrcOYnMsUxtzNfzc4dHA6oZT2T6vUtpxM=; b=JYCxRRsmeZwUeuImQ6GjgOoTvXLEiyjGQjbjspl0jWf5cuSeF3n7EoVM2d5sASHdBi 4jOzo5h8eTlE4WyingaYDxYZgRCo0rCoD71a1bQz5dSlQ1lyBtEcroHBHGyLx42C+54F ulxS6ja3X9Vf6yLglEQjq3BFxiAGdzz4LYpmHVN3ipiOaSCPW9Mi5SZ1dUsFGauSx9sB AO0SC193b/YcT1bFtyQlnLYvUMqz0WMqxguBh0OezzdXpEW9bvO43MuWHO+CdHuwZWTG IadOx/DYLxZaGjwfph5p+ru8yUlt8bdvduXcpPmz7mzZrdWS4YoMtkQ1fXFfEaozDtQB HJMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d8rYa6uc2lMrcOYnMsUxtzNfzc4dHA6oZT2T6vUtpxM=; b=fMQV6+NrBjPz/ee43MgFypz8UTXuHmty1rsk8PjvGDldHnyObnjQmorqimsM9m0T17 20oldrlITgvtpB7mXDq/EJuTa+gJuVHvbkgFvcBx72HVgzxHUeHzZ8yzAT0jhxvh2rqx rhRg4Mk1OONW1oiWKkXcq9QQRL44LY1EcMQXGW7SYk8vyj57MRihiOUuyDE48szCC91l xMQgKGuLjIfvAOsBZQBSTwQEtDAOH8XxMSKeXCNY9Dw2Xowf509PylFUu4h075MYZ/7E Qj9Xp+b73tGmHL8AwL15lWirP7VMtNsQ1sdTUiR6SVsmS1i0o9rn3kyTZRb26T1XBIdC EUDA== X-Gm-Message-State: AOAM532JM8+EoHXik0v48gzW8bwVWF8hAXzDCW+ec4ZbrKHHIQtCeGDx XpKPEKw+AIH0NR+nIqVTMuI= X-Received: by 2002:a05:6402:17fc:: with SMTP id t28mr4833221edy.283.1619776408947; Fri, 30 Apr 2021 02:53:28 -0700 (PDT) Received: from linux.local (host-79-52-107-152.retail.telecomitalia.it. [79.52.107.152]) by smtp.gmail.com with ESMTPSA id f30sm1626861ejl.62.2021.04.30.02.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 02:53:28 -0700 (PDT) From: "Fabio M. De Francesco" To: outreachy-kernel@googlegroups.com, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Cc: "Fabio M. De Francesco" Subject: [Outreachy kernel] [PATCH v2 2/2] staging: rtl8723bs: core: Remove set but unused variable Date: Fri, 30 Apr 2021 11:53:19 +0200 Message-Id: <20210430095319.23226-3-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210430095319.23226-1-fmdefrancesco@gmail.com> References: <20210430095319.23226-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Removed set but unused variable. Issue detected by gcc. Signed-off-by: Fabio M. De Francesco --- Changes from v1: As suggested by Dan Carpenter, removed no more needed curly braces around single statement blocks. drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index a2fdd5ea5fc4..4df03f0a1242 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1019,7 +1019,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame) u16 capab_info; struct rtw_ieee802_11_elems elems; struct sta_info *pstat; - unsigned char reassoc, *p, *pos, *wpa_ie; + unsigned char *p, *pos, *wpa_ie; unsigned char WMM_IE[] = {0x00, 0x50, 0xf2, 0x02, 0x00, 0x01}; int i, ie_len, wpa_ie_len, left; unsigned char supportRate[16]; @@ -1039,13 +1039,10 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame) return _FAIL; frame_type = GetFrameSubType(pframe); - if (frame_type == WIFI_ASSOCREQ) { - reassoc = 0; + if (frame_type == WIFI_ASSOCREQ) ie_offset = _ASOCREQ_IE_OFFSET_; - } else { /* WIFI_REASSOCREQ */ - reassoc = 1; + else /* WIFI_REASSOCREQ */ ie_offset = _REASOCREQ_IE_OFFSET_; - } if (pkt_len < sizeof(struct ieee80211_hdr_3addr) + ie_offset) -- 2.31.1