Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030296AbWJTJ1B (ORCPT ); Fri, 20 Oct 2006 05:27:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030239AbWJTJ1B (ORCPT ); Fri, 20 Oct 2006 05:27:01 -0400 Received: from hp3.statik.TU-Cottbus.De ([141.43.120.68]:23202 "EHLO hp3.statik.tu-cottbus.de") by vger.kernel.org with ESMTP id S932228AbWJTJ1A (ORCPT ); Fri, 20 Oct 2006 05:27:00 -0400 Message-ID: <45389662.6010604@s5r6.in-berlin.de> Date: Fri, 20 Oct 2006 11:26:58 +0200 From: Stefan Richter User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.5) Gecko/20060721 SeaMonkey/1.0.3 MIME-Version: 1.0 To: Randy Dunlap CC: Al Viro , Linus Torvalds , Alexey Dobriyan , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: dealing with excessive includes References: <20061017005025.GF29920@ftp.linux.org.uk> <20061017043726.GG29920@ftp.linux.org.uk> <20061018044054.GH29920@ftp.linux.org.uk> <20061018091944.GA5343@martell.zuzino.mipt.ru> <20061018093126.GM29920@ftp.linux.org.uk> <20061018160609.GO29920@ftp.linux.org.uk> <20061020005337.GV29920@ftp.linux.org.uk> <20061019213545.bf5a51c1.rdunlap@xenotime.net> In-Reply-To: <20061019213545.bf5a51c1.rdunlap@xenotime.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2414 Lines: 51 Randy Dunlap wrote: > Here's about half of checking includers of linux/smp_lock.h to see > if they actually use any of its interfaces. (most don't) > > Yet to do: fs/* and arch/* > Built only on x86_64. [...] > drivers/acpi/osl.c | 1 - > drivers/block/acsi_slm.c | 1 - > drivers/block/umem.c | 1 - > drivers/char/ds1620.c | 1 - > drivers/char/dsp56k.c | 1 - > drivers/char/dtlk.c | 1 - > drivers/char/ec3104_keyb.c | 1 - > drivers/char/ftape/zftape/zftape-init.c | 1 - > drivers/char/hangcheck-timer.c | 1 - > drivers/char/ip27-rtc.c | 1 - > drivers/char/lp.c | 1 - > drivers/char/mem.c | 1 - > drivers/char/mxser.c | 1 - > drivers/char/ppdev.c | 1 - > drivers/char/sysrq.c | 1 - > drivers/char/vc_screen.c | 1 - > drivers/char/watchdog/omap_wdt.c | 1 - > drivers/char/watchdog/pcwd_usb.c | 1 - > drivers/i2c/busses/scx200_acb.c | 1 - > drivers/i2c/i2c-dev.c | 1 - > drivers/ieee1394/raw1394.c | 1 - > drivers/infiniband/ulp/iser/iser_verbs.c | 1 - > drivers/input/evdev.c | 1 - > drivers/input/input.c | 1 - [... etc. pp. ...] > sound/oss/swarm_cs4297a.c | 1 - > sound/oss/trident.c | 1 - > sound/oss/via82cxxx_audio.c | 1 - > 166 files changed, 166 deletions(-) [...] I am afraid in many of these cases a proper cleanup would _replace_ the include by the correct one, not just delete it. For example, drivers/ieee1394/raw1394.c should include linux/spinlock.h. AFAICS it does so at the moment only indirectly via another header. -- Stefan Richter -=====-=-==- =-=- =-=-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/