Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp298240pxy; Fri, 30 Apr 2021 05:50:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCEFVeWUz8GxuDnO1ZnhRX3epB7v4wCeMFHCr3v9ogEDMLViGDsULrSMMxNSspt4Zx7osN X-Received: by 2002:a17:906:8a51:: with SMTP id gx17mr1845801ejc.549.1619787020657; Fri, 30 Apr 2021 05:50:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619787020; cv=none; d=google.com; s=arc-20160816; b=MjMzCFeNTKVRLLHRiCC5vFwMP+276JzptWmISMnrED/kDG0LFX+ESkkcsuF/sTSfcg OD9oXNc7me4+M9bNIgJ1kVxUWwANMETRhmccBAEzC4rMTc3S5rpHryYj6nmVYvKpyL1s MDHiqgRLc6JQC88Qig4JkIOf/sBKJiPvgZlsoouswyvJoL/Vwj7br+zVT4utKrLbk27y dOmzGQqligEx0nGCkf8bWU1ZiO7gnkj9aLFlo+ESC+K3FIMS7njxqlm0DlT7ACRKs1P/ 4lrne3HR3y+GX4KG3bC4V0wiAhUw4xDIPwTSyyf8tvH+YyZvqphikFgmr3+cTzy7sgMr FWsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=jw66FmD8Th0QIlNzmRqWGxuyLSOR24g11ihkkzBg7Ko=; b=dl0O9p/PX3O3kO0BH16Wf/tiHPelzn8T3ZBH+RhA9NIHguIPZ9bT358V8ih+W9L18a hk7V6sZMOb9sqtuz6FPuYRgUgqsORRhoSNJWUBUa2WlvRg/u0neYk1BE1rJSkVi0XRE6 /Lh+aj4LzOADxYFVSARuj5gezWtPTK1HjGBCsEI/qjxDRlvAzTzhmVyhDYHeQJLUTP9C 9a/6rQtYoI5y3GENQ0qvecWWCi4k7VvJJXysOi0ox8IFIk7uHzr0N0Too+McY2AaK3va 5oPD6kBWA2ho3T5G/1e5ZREDx3l0WCgsl39grfvWnaLenhg3Z8vtpBF85kIWbWNVMndB ud3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=hlGRePka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v26si1650615edy.391.2021.04.30.05.49.50; Fri, 30 Apr 2021 05:50:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=hlGRePka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232408AbhD3MrE (ORCPT + 99 others); Fri, 30 Apr 2021 08:47:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232255AbhD3Mqw (ORCPT ); Fri, 30 Apr 2021 08:46:52 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 497B1C06134C for ; Fri, 30 Apr 2021 05:44:42 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id q10so49344647pgj.2 for ; Fri, 30 Apr 2021 05:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jw66FmD8Th0QIlNzmRqWGxuyLSOR24g11ihkkzBg7Ko=; b=hlGRePkaxoY7sy4aSFDJZJ3iBE4O2EHbsMruaZcDCC25qBXEfd3VPxCjyljt+WdSYA aGiSP8uZK5FGAyE8i8N4TUND0N5t3WzIGT7ApYUye2cZ/S6Bj7agyrzar9AbylkmAglL q6uGsnISmgxKgPqgwyIzvz+BUeDKscJOxj1NscyaQBVo44cP57H43cGKhCaDlFRyN3D9 +8gknEmQIvz2hB/Zg+oYfyvUWrz1R/8HXwu2DZmMKlEhdrMird+6gqzITaZlHdZOtOct EFLw5+hqAr4WyVUh/iBNMsm6+R0T1Yr+btQzMf6c+QrIZRly0ZI1ifYk9tLcBBS06AK3 rk8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jw66FmD8Th0QIlNzmRqWGxuyLSOR24g11ihkkzBg7Ko=; b=Nllf7wnT/FTHXU4fpC0J2aFCCQ00x/ZJ53FrpUJbMyvnSpuaPF9KhzA6pGHw45fRR/ AkIWCQfomxz4owLGxvhFWr6JeqjB05BrRUzP26fqTKhT/jTkQ4IhKK0To3p0TbDqa9Ag kluNhBEiVFPIL7+LfTf6E1rmrEDPN6UsIeR5GVvCcPfcVnQldeWMdJdJ3HfHbFffr8Ga IWzrq+aF4Rm0shyF5kPPQvymEIk/bhQx9u7/93wC/nbrfZJCLp+gvi079wVtd4viEMsJ OFNQQXNtkAIw9e2z7hG7SjXf5s0WMsebXEDYCs0F0KGQUm5D12clqELTzIp/9oC+AkvK +0rg== X-Gm-Message-State: AOAM5307/yOGN/u13IDGOsCaqwLKVLn/prmUiq0Coz7664KQjo2fnSHQ NGCVrLf6wTYhx6ezwX7oFMCx6P/D9NAPDg== X-Received: by 2002:a63:f957:: with SMTP id q23mr4522088pgk.430.1619786681543; Fri, 30 Apr 2021 05:44:41 -0700 (PDT) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id x38sm2145473pfu.22.2021.04.30.05.44.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 05:44:41 -0700 (PDT) Subject: Re: [PATCH] io_uring: Fix memory leak in io_sqe_buffers_register() To: qiang.zhang@windriver.com, io-uring@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20210430082515.13886-1-qiang.zhang@windriver.com> From: Jens Axboe Message-ID: <51a36bba-c6d7-1e31-36d2-899466738e97@kernel.dk> Date: Fri, 30 Apr 2021 06:44:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210430082515.13886-1-qiang.zhang@windriver.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/30/21 2:25 AM, qiang.zhang@windriver.com wrote: > From: Zqiang > > unreferenced object 0xffff8881123bf0a0 (size 32): > comm "syz-executor557", pid 8384, jiffies 4294946143 (age 12.360s) > backtrace: > [] kmalloc_node include/linux/slab.h:579 [inline] > [] kvmalloc_node+0x61/0xf0 mm/util.c:587 > [] kvmalloc include/linux/mm.h:795 [inline] > [] kvmalloc_array include/linux/mm.h:813 [inline] > [] kvcalloc include/linux/mm.h:818 [inline] > [] io_rsrc_data_alloc+0x4f/0xc0 fs/io_uring.c:7164 > [] io_sqe_buffers_register+0x98/0x3d0 fs/io_uring.c:8383 > [] __io_uring_register+0xf67/0x18c0 fs/io_uring.c:9986 > [] __do_sys_io_uring_register fs/io_uring.c:10091 [inline] > [] __se_sys_io_uring_register fs/io_uring.c:10071 [inline] > [] __x64_sys_io_uring_register+0x112/0x230 fs/io_uring.c:10071 > [] do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47 > [] entry_SYSCALL_64_after_hwframe+0x44/0xae > > Fix data->tags memory leak, through io_rsrc_data_free() to release > data memory space. Applied, thanks. -- Jens Axboe