Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] scsi: target: configfs: Remove redundant assignment to
 ret
To:     Bodo Stroesser <bostroesser@gmail.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1619774627-118766-1-git-send-email-jiapeng.chong@linux.alibaba.com>
 <69ef77bd-4ef8-6446-8192-6d8569516f33@gmail.com>
From:   michael.christie@oracle.com
Message-ID: <90e67d9f-e524-62b4-df04-2ea2ea28559c@oracle.com>
Date:   Fri, 30 Apr 2021 10:40:20 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.0
In-Reply-To: <69ef77bd-4ef8-6446-8192-6d8569516f33@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [20.15.0.5] (73.88.28.6) by DM5PR13CA0055.namprd13.prod.outlook.com (2603:10b6:3:117::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.8 via Frontend Transport; Fri, 30 Apr 2021 15:40:22 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f9b5c4ef-e62d-4c4b-ded0-08d90bee44a4
X-MS-TrafficTypeDiagnostic: BYAPR10MB2581:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR10MB25810B68FADB22E52C778C4EF15E9@BYAPR10MB2581.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SahnC4AyaO8N/o3Fj1IGoeCHKp/+al6GRrkHGYAii0ClWMHLRDyuoNmbVAcQc9I0aNAWPwMAWMYy4c0yuHAo2cTiZv0cD53g/xZE+CXHjK4UOycaplb9exL8HGDxcOsQw72cmBK1lyhdADlGumxTzGhcTsGdVqKwRGNf0AsrZ6lyoZ6/Ha2MCgcAhUyyiosEVL+7tpgfXDCaYj+2cy0aVgnPlt9PslexzGEiDzQ6Hhs+Tq3ke3UOzDvKlcxwh9JQtULu5jaoHCviN9E88FRXrJVTZl7FqhPsimHkV9PM19XsW3DfHkXJExIBfY60lUi1vMTNxDD2RlKc/1NDAjETON2qjitiHhTs7TOprFIwynRQHTMZPoQg4t292Ztgy9dsYyK5N4uYZmYa1eJ4hXtOsyZviFrgQiloFcc1g1aShMNKfZTP3DH/bDbVwIXZNRoKy+rdd4JmDDDszdZniY7Ykkw65ZGBSgyZfA2djDDgv0RIB6dbynmI4hlgYifW/Auv4kwq7cxLp5867Irx2eO310AR/dUmWbTncWz5kvdg9xVatmh/BVZOECM9JbSfWxB7HivPqG7V2VYeQMIDN1FwSQC+7DSppMEnBflEfJp9Xw5Yq9gJliXnbXv5i1li3cidN6hXi5tbwLuJEKegN1Cci5UVMCEIw+L6IszAi8YLUzWlITxrEsF9MTQftzJjoPj4opLeM8YVp/PyHdCZvQJUXayPbz3ZpNUpfO/XZxJzom7unlD39sX4cLd1p5MF5tv2
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3573.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(396003)(136003)(376002)(366004)(6486002)(66476007)(86362001)(110136005)(186003)(16526019)(2616005)(53546011)(26005)(316002)(31686004)(16576012)(31696002)(36756003)(8936002)(6706004)(38100700002)(956004)(4744005)(9686003)(4326008)(66946007)(966005)(478600001)(8676002)(5660300002)(2906002)(66556008)(78286007)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RU13NE81Ukl6ajdiZVhWRS9rMXp6YzhDQ0t6VytmLzZZMk5RRlZQclF5ZFBj?=
 =?utf-8?B?VXVUQ2RHUTIxeE14NCtiWEZsZjdJRUxWNUlYdEx0S0NzQXRTa01rRDhtOUZW?=
 =?utf-8?B?M0dKVHA2c1NCNkNUNVdVcXUzL01ZUWt1YmprSEk0Y280Wm9KbVVyMm13WWND?=
 =?utf-8?B?MHBJQ3RFY1QvK0NVWU5TSk02ZWRtcGNWR1k5ZzZ0cGQxcmlnbC84MC93aXJm?=
 =?utf-8?B?L1FqVUJBNmZPMUE4dEFHaWlBbGVGZnVmUnJ0aEJWTHRMcHEyd05ZTkNuT1BQ?=
 =?utf-8?B?Z1VJS2N2bURXcUJEcCtGM2FzUHU0MWpvcGU1ZG9Da29QSFY1cU5ab2NGTEJo?=
 =?utf-8?B?QzJWa1JZREUydktmSjRtT1RNQzB3eGFOMG9IMkpFNVl5ZmtZY3I2akdIdVBs?=
 =?utf-8?B?REluc3M0UDNNZ0VyYmZpSThSSUJMRnA0akJrR0o1Z2E5SFN1UUFnTng4dTJN?=
 =?utf-8?B?K1RXc3pYOEpSYmk5VitXekU1akpEbFhEYmFPQ3FzWTFkQjd2Mi85ZWZ4Mmcx?=
 =?utf-8?B?aVRLaEZZSWVPRnlReW56RDZCWXV2Wjc2OVlJUVpkRnIzc1hLNC8vdkxQSmtM?=
 =?utf-8?B?RmI3elhveEJSMDNTMjhyRnI1TWIxSytJK1dFa2NicHh1UExQcmFNelU2VTVQ?=
 =?utf-8?B?R0pGZ3lna3ppb2hHMTFpMlFOTjREdSt3aGJEdXVJVzUyZDJwUjZLcjkyckdi?=
 =?utf-8?B?ZXFNeGwyRzhDdGVGMXBaMCtEVzJ1Q0ZvUXI2Y1hzYStPVUY4ZXM4LzBOcnRP?=
 =?utf-8?B?YXJmTTB5cHQ0M2xkQk1CZEw3VU1pdlQrUlRVZ3V4NjVZZzFrZ1pwQU1NVTU3?=
 =?utf-8?B?cHEwYmxvQ1hZMXlhY29nOFZvREc2eW5DZ1dGdEhEWFF1OVZIR3dKUFlCV0FN?=
 =?utf-8?B?cExjcFNEMG14blh0cC80NnZWWXg1NEsyU2JNTWdYOW9wd0RjUndjMXdnRjhv?=
 =?utf-8?B?dzRSOFZKQ0NzZ0RTNUU3N2J2SE9hMHgzY0NwK2lYTkg4ZDRhdWpoaTk2L0lW?=
 =?utf-8?B?MmswSGRuaUYyd2ZEYTR1aE51LzNwVy9CUkxXWEs5STNEdnFpNUwrblRGVFV3?=
 =?utf-8?B?VGs0K09nL0VQK3dMSDFqMDh4aEFIbzRLeGpoQXRFTHlsQnZIdXRrZkR0WXlG?=
 =?utf-8?B?R2M5RmRTdkxYZzZleVZaam1yRXMvUzBvUjRFWUR6ZTkwMW1JL1dPMGJOTm5R?=
 =?utf-8?B?R0FhL2NpTDVHTSs1WDVGaTFHdHhlSTZxdklrMjRtQmxrZHNmdVJxRG1kQWRI?=
 =?utf-8?B?WUFrTTlIUzhTMjBKTjJnZDZHYXlGREVXV0xpQjlMajVFVitiQUpqMHBFL0dr?=
 =?utf-8?B?TEM2UEk2cTZnZ3JMaFBxcHJaa1VIV1BVTEgxelVBN2o1MTZ5RVpURTIwV1JQ?=
 =?utf-8?B?d2g5Umc0R0Y0WXNLNG1nVEdOM3N5R29kcEpnMEZjSjA0dlBlbmwzdnJUWGFB?=
 =?utf-8?B?c2M1QXZibUJBbitkUGlJc0hRY29SeE10M1JmeTd6V1ZtOEpMRnhOb1dNSVZo?=
 =?utf-8?B?QVk5YVJ6bFU3QUs2OU1Od1FXb0dQQjhUZzFGMFNRUENZRjRsUzdTV2RXYjdK?=
 =?utf-8?B?cE1sV0tRZHFEQXczMGpnNWJWaHo5OUViZlVpR1FrcStCVXVjYmVDQWU4Ukdr?=
 =?utf-8?B?N2JKb3l6UVFhNzlRU052ZWg1b0xlYjAwQWFNeVdGL1JuN0tGL1Z3RDdpS1RH?=
 =?utf-8?B?U016RjFuTkVMYWtFNzhwY1c3Q0lBUVZEWFcybHhJeGNocHFXb2ZVdWI1Tjdl?=
 =?utf-8?Q?K3haJvkSOkPLU1gDtjMbnk6N4HZ/gY71T57ytkI?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9b5c4ef-e62d-4c4b-ded0-08d90bee44a4
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3573.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2021 15:40:23.3412
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tyle8dx+NTohxyw/xZI55kG8SfveN89f5YFi3UUmhFyPzlxsKHZ7ROfSdAK5fjyD8kUqQR2Gyh7jMPIP3Q8QvHBCraKs6+Xl91TIhdR3KTQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2581
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9970 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0
 mlxlogscore=999 malwarescore=0 bulkscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000
 definitions=main-2104300105
X-Proofpoint-GUID: JB_Ib7CDaUG2UsCpo6-3hFXfK0TQANvT
X-Proofpoint-ORIG-GUID: JB_Ib7CDaUG2UsCpo6-3hFXfK0TQANvT
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9970 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 mlxlogscore=999
 priorityscore=1501 clxscore=1011 adultscore=0 suspectscore=0 spamscore=0
 phishscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000
 definitions=main-2104300105
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/30/21 9:29 AM, Bodo Stroesser wrote:
> BTW: why is "initiator_sid" input handled as string?
> core_scsi3_alloc_aptpl_registration later calls get_unaligned_be64 for
> that string. I don't think this makes sense.

It's broken.

Remember the isid patches that you reviewed of mine trying to fix the
isid code in target_core_transport.c? I can't remember all the details but
I think it was that the aptpl code thinks the buffer is in the format that
sess_get_initiator_sid uses and is trying to do something similar as
target_core_transport.c.

I can't find the version of the patches you had looked at. This was the first
version of the patch:

https://patchwork.kernel.org/project/target-devel/patch/1531696591-8558-3-git-send-email-mchristi@redhat.com/