Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] scsi: target: configfs: Remove redundant assignment to
 ret
To:     michael.christie@oracle.com,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1619774627-118766-1-git-send-email-jiapeng.chong@linux.alibaba.com>
 <69ef77bd-4ef8-6446-8192-6d8569516f33@gmail.com>
 <90e67d9f-e524-62b4-df04-2ea2ea28559c@oracle.com>
From:   Bodo Stroesser <bostroesser@gmail.com>
Message-ID: <3fad772f-51da-6415-76a4-ed248736ced5@gmail.com>
Date:   Fri, 30 Apr 2021 17:43:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <90e67d9f-e524-62b4-df04-2ea2ea28559c@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 30.04.21 17:40, michael.christie@oracle.com wrote:
> On 4/30/21 9:29 AM, Bodo Stroesser wrote:
>> BTW: why is "initiator_sid" input handled as string?
>> core_scsi3_alloc_aptpl_registration later calls get_unaligned_be64 for
>> that string. I don't think this makes sense.
> 
> It's broken.
> 
> Remember the isid patches that you reviewed of mine trying to fix the
> isid code in target_core_transport.c? I can't remember all the details but
> I think it was that the aptpl code thinks the buffer is in the format that
> sess_get_initiator_sid uses and is trying to do something similar as
> target_core_transport.c.
> 
> I can't find the version of the patches you had looked at. This was the first
> version of the patch:
> 
> https://patchwork.kernel.org/project/target-devel/patch/1531696591-8558-3-git-send-email-mchristi@redhat.com/
> 

Ahh, yes. I remember. Thank you.