Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next v1 1/1] net: selftest: provide option to disable
 generic selftests
To:     Andrew Lunn <andrew@lunn.ch>,
        Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Fugang Duan <fugang.duan@nxp.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        kernel@pengutronix.de, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com, Fabio Estevam <festevam@gmail.com>,
        David Jander <david@protonic.nl>,
        Russell King <linux@armlinux.org.uk>,
        Philippe Schenker <philippe.schenker@toradex.com>
References: <20210430095308.14465-1-o.rempel@pengutronix.de>
 <f0905c84-6bb2-702f-9ae7-614dcd85c458@infradead.org>
 <20210430154153.zhdnxzkm2fhcuogo@pengutronix.de> <YIwu+4ywaTI4+eUq@lunn.ch>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <6865cd7a-7f2e-13f5-a588-8877d771b834@infradead.org>
Date:   Fri, 30 Apr 2021 09:33:42 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <YIwu+4ywaTI4+eUq@lunn.ch>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/30/21 9:23 AM, Andrew Lunn wrote:
>>> Thanks for the patch/option. But I think it should just default to n,
>>> not PHYLIB.
>>
>> It should be enabled by default for every device supporting this kind of
>> selftests.
> 
> I agree.
> 
> I still wonder if there is confusion about self test here. Maybe

Probably.

> putting ethtool into the description will help people understand it
> has nothing to do with the kernel self test infrastructure and kernel
> self testing.

So it's a hardware check that is required to be run if it's implemented
in a driver?

Required by who/what?

thanks.
-- 
~Randy