Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp550546pxy; Fri, 30 Apr 2021 10:48:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx04GYvZ+IO35w2zyVsC90tuHBroaUPq3YGx8kXZrbzgWYZa8VH86Wcnp0qG1Bsq4CLfcn1 X-Received: by 2002:a17:902:9008:b029:e6:f37a:2183 with SMTP id a8-20020a1709029008b02900e6f37a2183mr6238159plp.49.1619804900537; Fri, 30 Apr 2021 10:48:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619804900; cv=none; d=google.com; s=arc-20160816; b=eHYPliCAcxUBkeK4TZi1Sp4e24xMr3OGXWKw4p36Qsw1EmrY6J4ZvRQYxEvS9f1b5V 4xPMQK7SVsFtxLs4FHNiRqUcuahxY+/Qs+QGYgxRyXSHporNI0OAoK0QxxwQkKztcgMy KYTDxi2TnlNZvFUii4VHUySs1+Rm1ZezvYnevQX7yi1i+pNMiQhzFM/jD7cOZ1JE9U5w eB4MofnYu2G/APxZzWqMaFw2yfudOhCrD4mSB6rJ2m5r2bOPQ7p8efyfqjRQ6Y3UHhlp gkA7mpvxxUxvHEtOoyi49JQUiu93j8qJ3HcIbF9li6IhnCjS95W2zI5WGE9cHMIzC+Ue CY/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=FppRkL+figBQ7jdEmVWN1oXdvFZjrgJI90KcyAk643o=; b=pplaHrPWxLpG3X15GsJYhdtcLaIpHyoc1esv1K/46zj9vJ00rg0wbxsDGl25TISohq K+fmc/zH14m4IjCAOTDeM4SZnSEtNc+l5YueX4WV0M7+2EOEfXWltMzh5gk61cJz7UPG USoiAE6r1m5z4H5gAVykwK/+mmvnx/QA7A/M+kM6HG35lHDhy8af3zXgRyj404AwYDWs RrFSILZghqn4Ha0jDCC5YiDrG40+wZNGl7gGVK0nKPmJqlKDJNttVt3RuyHCyRAcPa8x rpYqlXbyO8BLLUJ5Z6viuXCIvL3CtTwGez0EUJcM+1agnizBncgBahDNBGfZYJIBA+lV 819w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x3si3943596pgl.58.2021.04.30.10.48.07; Fri, 30 Apr 2021 10:48:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230475AbhD3RsT (ORCPT + 99 others); Fri, 30 Apr 2021 13:48:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:51692 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbhD3RsR (ORCPT ); Fri, 30 Apr 2021 13:48:17 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C7C9EB0BD; Fri, 30 Apr 2021 17:47:25 +0000 (UTC) Date: Fri, 30 Apr 2021 19:47:23 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Jiri Olsa Cc: Yonghong Song , linux-kernel@vger.kernel.org, Martin KaFai Lau , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Song Liu , John Fastabend , KP Singh , netdev@vger.kernel.org, bpf@vger.kernel.org, Jiri Olsa , Jesper Dangaard Brouer , jslaby@suse.com Subject: Re: linux-next failing build due to missing cubictcp_state symbol Message-ID: <20210430174723.GP15381@kitsune.suse.cz> References: <316e86f9-35cc-36b0-1594-00a09631c736@fb.com> <20210423175528.GF6564@kitsune.suse.cz> <20210425111545.GL15381@kitsune.suse.cz> <20210426113215.GM15381@kitsune.suse.cz> <20210426121220.GN15381@kitsune.suse.cz> <20210426121401.GO15381@kitsune.suse.cz> <49f84147-bf32-dc59-48e0-f89241cf6264@fb.com> <20210427121237.GK6564@kitsune.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210427121237.GK6564@kitsune.suse.cz> User-Agent: Mutt/1.11.3 (2019-02-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CC another Jiri On Tue, Apr 27, 2021 at 02:12:37PM +0200, Michal Such?nek wrote: > On Mon, Apr 26, 2021 at 09:16:36PM +0200, Jiri Olsa wrote: > > On Mon, Apr 26, 2021 at 06:03:19PM +0200, Jiri Olsa wrote: > > > On Mon, Apr 26, 2021 at 08:41:49AM -0700, Yonghong Song wrote: > > > > > > > > > > > > On 4/26/21 5:14 AM, Michal Such?nek wrote: > > > > > On Mon, Apr 26, 2021 at 02:12:20PM +0200, Michal Such?nek wrote: > > > > > > On Mon, Apr 26, 2021 at 01:32:15PM +0200, Michal Such?nek wrote: > > > > > > > On Sun, Apr 25, 2021 at 01:15:45PM +0200, Michal Such?nek wrote: > > > > > > > > On Fri, Apr 23, 2021 at 07:55:28PM +0200, Michal Such?nek wrote: > > > > > > > > > On Fri, Apr 23, 2021 at 07:41:29AM -0700, Yonghong Song wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 4/23/21 6:05 AM, Michal Such?nek wrote: > > > > > > > > > > > Hello, > > > > > > > > > > > > > > > > > > > > > > I see this build error in linux-next (config attached). > > > > > > > > > > > > > > > > > > > > > > [ 4939s] LD vmlinux > > > > > > > > > > > [ 4959s] BTFIDS vmlinux > > > > > > > > > > > [ 4959s] FAILED unresolved symbol cubictcp_state > > > > > > > > > > > [ 4960s] make[1]: *** > > > > > > > > > > > [/home/abuild/rpmbuild/BUILD/kernel-vanilla-5.12~rc8.next.20210422/linux-5.12-rc8-next-20210422/Makefile:1277: > > > > > > > > > > > vmlinux] Error 255 > > > > > > > > > > > [ 4960s] make: *** [../Makefile:222: __sub-make] Error 2 > > > > > > this one was reported by Jesper and was fixed by upgrading pahole > > > that contains the new function generation fixes (v1.19) > > > > > > > > > > > > > > > > > > > > > > > Looks like you have DYNAMIC_FTRACE config option enabled already. > > > > > > > > > > Could you try a later version of pahole? > > > > > > > > > > > > > > > > > > Is this requireent new? > > > > > > > > > > > > > > > > > > I have pahole 1.20, and master does build without problems. > > > > > > > > > > > > > > > > > > If newer version is needed can a check be added? > > > > > > > > > > > > > > > > With dwarves 1.21 some architectures are fixed and some report other > > > > > > > > missing symbol. Definitely an improvenent. > > > > > > > > > > > > > > > > I see some new type support was added so it makes sense if that type is > > > > > > > > used the new dwarves are needed. > > > > > > > > > > > > > > Ok, here is the current failure with dwarves 1.21 on 5.12: > > > > > > > > > > > > > > [ 2548s] LD vmlinux > > > > > > > [ 2557s] BTFIDS vmlinux > > > > > > > [ 2557s] FAILED unresolved symbol vfs_truncate > > > > > > > [ 2558s] make[1]: *** > > > > > > > [/home/abuild/rpmbuild/BUILD/kernel-kvmsmall-5.12.0/linux-5.12/Makefile:1213: > > > > > > > vmlinux] Error 255 > > > > > > > > This is PPC64, from attached config: > > > > CONFIG_PPC64=y > > > > I don't have environment to cross-compile for PPC64. > > > > Jiri, could you take a look? Thanks! > > > > > > looks like vfs_truncate did not get into BTF data, > > > I'll try to reproduce > > > > I can't reproduce the problem, in both cross build and native ppc, > > but the .config attached does not see complete, could you pelase > > resend? > > I can't reproduce outside of the build service either. There is probably > some other tool missing that is commonly available and there is no check > for it. Looks like pahole or some library are miscompiled on ppc64. Using the native ppc64 tools is broken and using cross-tools works. Thanks Michal