Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp622124pxy; Fri, 30 Apr 2021 12:32:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGxsFoPSC3D1DSd3AsSl9HeOXxXr149WVotAMNVEjCS5h73yFmjBwgeiQZk5QxX4n/ZDxw X-Received: by 2002:a17:902:f284:b029:ed:1840:5cad with SMTP id k4-20020a170902f284b02900ed18405cadmr6679168plc.34.1619811176536; Fri, 30 Apr 2021 12:32:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619811176; cv=none; d=google.com; s=arc-20160816; b=YrBwScpBiQkAogqqI4SYOSUiUcnSBVIGhPBYazhBJdvbLDbuBopEjIeNk9j9U+3QDP 7uflAVQqlNsMxwhgnmkJT5BkMJAl/3MDsHjPI9IQhNDX6oOdB6r13cEFO0YTTCt/ZKfA gWEZCsKTrykZBc+XuMaSbvGrrKB4iYIJc4c3NwX8sC1JP4b3DbZpmnY/M/TUX9qBikOj RImYFKuuq7yt3cK16tb+f/CjUokMuZqn2y2f5WbtCahInYUfuROm5/LzSLMRjW2oiPgc uQBB9qm7u8wfxT1Xr1lT0m+XbbmmKPR0N7F0WIgJAzFk+1NecN+lt7klyuNku+ACH/WV yIbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zoyc92td/lrE+1cEtuWT2gS23XHAVp7Jh+/xM6e703E=; b=KTx8VY3UBLHdNo5WbRLgkni06sOVTiYdS/Qf8PZNveqTJMhX7wvTPig+d3mVbDSGso 8lX5FvAzPg+vK14xdl7wO2kE9lFPH8assg+ycgSsKPI8IyCXZhpa/qmhCB3FN7VpY7Kf xR9JLOU/84yJrZOL9+hCk/y2VT2Pm4YXs/Key3c3w+GClBi8lpJ21YGom34ZBaqaeoAX +rm6XA2+iz1IF5MaDTdETqMHHRH1cATBCpd4MAtZvNBe+Eac8Q+MByqheS817jc4eI5s +N5VbX3hFDkkTzfUB9YKUypMo5ta1v37qVONZNK2NHqysMsxCqnPe1s+YSVJ5kGty7CR w91Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=I7NSjPjc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v8si4449179ply.40.2021.04.30.12.32.44; Fri, 30 Apr 2021 12:32:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=I7NSjPjc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232286AbhD3TcW (ORCPT + 99 others); Fri, 30 Apr 2021 15:32:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbhD3TcC (ORCPT ); Fri, 30 Apr 2021 15:32:02 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87589C061343 for ; Fri, 30 Apr 2021 12:31:12 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id d10so11705497pgf.12 for ; Fri, 30 Apr 2021 12:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zoyc92td/lrE+1cEtuWT2gS23XHAVp7Jh+/xM6e703E=; b=I7NSjPjcc21r8BP/rzm9f+bbrdMrSfdOl1GG7A81BEWaP0eiPpYbOjNGk04Ui5rJTG /eJftYzh6EbB1TLCDCYovgIRxImMDyaBvtXHbZGYrTi7TpyW3dhW15ajxXC6WM4+kmQI BD+z0XK9QOaHRLs6w0I3P6ck8mPCG4Qp1zfWw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zoyc92td/lrE+1cEtuWT2gS23XHAVp7Jh+/xM6e703E=; b=iy4PkAh6lhDWKmMuOd2AubnDnUKVgNQUH3BEaUbW5wNA4y/diixNA/cGsxNFXQ8kKF nF92xNN22xmAmbyIoFmJArjHD8Wlsn1T0rOikSswIodxqCHpNf3BecWBQJVnMn9nBNTK ebZhjxCHml5VuSNrjr55GdMHaPxIFo5+KhosUs+e8zLkulAvUKEq2il9553eAx+i9DIv OPT6d3GCJLThCQZArjZZS/72HPEP+M0g9UM2ys4652a98RDRSIA4TXrIp3yhWrZl2L7x W4t6ixm5fs1K7H52mAvQUdFCB9t2jnPjV6/KnMQ331XA/AykGZSPZX32OUwD5k5grigj v81A== X-Gm-Message-State: AOAM531ycUjZ8pNJRZlhTGUn8JECvkwj6HJCzu90E7WqsIDbuVug68EH tJ6LJyiUmrr++XWHpQJZW6brww== X-Received: by 2002:a05:6a00:b82:b029:27f:dffe:214c with SMTP id g2-20020a056a000b82b029027fdffe214cmr6546945pfj.57.1619811072112; Fri, 30 Apr 2021 12:31:12 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:dacb:8fee:a41f:12ac]) by smtp.gmail.com with ESMTPSA id t6sm3143500pjl.57.2021.04.30.12.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 12:31:11 -0700 (PDT) From: Stephen Boyd To: Rob Clark Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Dmitry Baryshkov , Abhinav Kumar , Kuogee Hsieh , aravindh@codeaurora.org, Sean Paul Subject: [PATCH 5/6] drm/msm/disp: Use plane debug print helper Date: Fri, 30 Apr 2021 12:31:03 -0700 Message-Id: <20210430193104.1770538-6-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.527.g47e6f16901-goog In-Reply-To: <20210430193104.1770538-1-swboyd@chromium.org> References: <20210430193104.1770538-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the DPU_DEBUG_PLANE() helper to print the plane number instead of open coding it. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravindh@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index f898a8f67b7f..3f5626832c9e 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -283,8 +283,8 @@ static int _dpu_plane_calc_fill_level(struct drm_plane *plane, } } - DPU_DEBUG("plane%u: pnum:%d fmt: %4.4s w:%u fl:%u\n", - plane->base.id, pdpu->pipe - SSPP_VIG0, + DPU_DEBUG_PLANE(pdpu, "pnum:%d fmt: %4.4s w:%u fl:%u\n", + pdpu->pipe - SSPP_VIG0, (char *)&fmt->base.pixel_format, src_width, total_fl); @@ -353,8 +353,7 @@ static void _dpu_plane_set_qos_lut(struct drm_plane *plane, (fmt) ? fmt->base.pixel_format : 0, pdpu->is_rt_pipe, total_fl, qos_lut, lut_usage); - DPU_DEBUG("plane%u: pnum:%d fmt: %4.4s rt:%d fl:%u lut:0x%llx\n", - plane->base.id, + DPU_DEBUG_PLANE(pdpu, "pnum:%d fmt: %4.4s rt:%d fl:%u lut:0x%llx\n", pdpu->pipe - SSPP_VIG0, fmt ? (char *)&fmt->base.pixel_format : NULL, pdpu->is_rt_pipe, total_fl, qos_lut); @@ -406,8 +405,7 @@ static void _dpu_plane_set_danger_lut(struct drm_plane *plane, pdpu->pipe_qos_cfg.danger_lut, pdpu->pipe_qos_cfg.safe_lut); - DPU_DEBUG("plane%u: pnum:%d fmt: %4.4s mode:%d luts[0x%x, 0x%x]\n", - plane->base.id, + DPU_DEBUG_PLANE(pdpu, "pnum:%d fmt: %4.4s mode:%d luts[0x%x, 0x%x]\n", pdpu->pipe - SSPP_VIG0, fmt ? (char *)&fmt->base.pixel_format : NULL, fmt ? fmt->fetch_mode : -1, @@ -450,8 +448,7 @@ static void _dpu_plane_set_qos_ctrl(struct drm_plane *plane, pdpu->pipe_qos_cfg.danger_safe_en = false; } - DPU_DEBUG("plane%u: pnum:%d ds:%d vb:%d pri[0x%x, 0x%x] is_rt:%d\n", - plane->base.id, + DPU_DEBUG_PLANE(pdpu, "pnum:%d ds:%d vb:%d pri[0x%x, 0x%x] is_rt:%d\n", pdpu->pipe - SSPP_VIG0, pdpu->pipe_qos_cfg.danger_safe_en, pdpu->pipe_qos_cfg.vblank_en, @@ -506,8 +503,8 @@ static void _dpu_plane_set_qos_remap(struct drm_plane *plane) qos_params.num = pdpu->pipe_hw->idx - SSPP_VIG0; qos_params.is_rt = pdpu->is_rt_pipe; - DPU_DEBUG("plane%d pipe:%d vbif:%d xin:%d rt:%d, clk_ctrl:%d\n", - plane->base.id, qos_params.num, + DPU_DEBUG_PLANE(pdpu, "pipe:%d vbif:%d xin:%d rt:%d, clk_ctrl:%d\n", + qos_params.num, qos_params.vbif_idx, qos_params.xin_id, qos_params.is_rt, qos_params.clk_ctrl); -- https://chromeos.dev