Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210413065633.2782273-1-yuzhao@google.com> <140226722f2032c86301fbd326d91baefe3d7d23.camel@yandex.ru>
 <8ce5be3df2137e975d7333024b6120b71b214617.camel@yandex.ru>
In-Reply-To: <8ce5be3df2137e975d7333024b6120b71b214617.camel@yandex.ru>
From:   Yu Zhao <yuzhao@google.com>
Date:   Fri, 30 Apr 2021 13:31:57 -0600
Message-ID: <CAOUHufaoGe1=Vigp7cHbvx0G1=zvHQrNc_et4C9UTw4bYOSY8Q@mail.gmail.com>
Subject: Re: [PATCH v2 00/16] Multigenerational LRU Framework
To:     Konstantin Kharlamov <hi-angel@yandex.ru>
Cc:     Linux-MM <linux-mm@kvack.org>, Alex Shi <alexs@kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Benjamin Manes <ben.manes@gmail.com>,
        Dave Chinner <david@fromorbit.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Hillf Danton <hdanton@sina.com>, Jens Axboe <axboe@kernel.dk>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Matthew Wilcox <willy@infradead.org>,
        Mel Gorman <mgorman@suse.de>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Michael Larabel <michael@michaellarabel.com>,
        Michal Hocko <mhocko@suse.com>,
        Michel Lespinasse <michel@lespinasse.org>,
        Rik van Riel <riel@surriel.com>,
        Roman Gushchin <guro@fb.com>,
        Rong Chen <rong.a.chen@intel.com>,
        SeongJae Park <sjpark@amazon.de>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Yang Shi <shy828301@gmail.com>,
        Ying Huang <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, lkp@lists.01.org,
        Kernel Page Reclaim v2 <page-reclaim@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 30, 2021 at 12:38 AM Konstantin Kharlamov
<hi-angel@yandex.ru> wrote:
>
> Btw, I noticed a fun thing, an improvement. I don't know yet if it can be
> attributed to 5.12 (which I didn't try alone yet) or to the LRU patchset,=
 but
> I'd assume the latter, because 5.12 seems didn't to have had anything
> interesting regarding memory performance=C2=B9.

I appreciate the testing and the report. They mean a lot to us.

This improvement is to be expected, and it works both ways. There are
cases that swapping is not a good idea, for example, when building
large repos. Without this patchset, some of my browser memory usually
gets swapped out while tons of memory is used to cache files I don't
really care about.

I completely agree with you on the memory cgroup part: theoretically
it could work around the problem but nobody knows how much memory to
reserve for Skype or Firefox :)

I will keep you posted on the following developments.

Thanks!

> I usually have Skype running in background for work purposes, which is on=
ly used
> 2-3 times in a week. So one would expect it to be one the first victims t=
o
> memory reclaim. Unfortunately, I never seen this to actually happen (till=
 now,
> that is): all skypeforlinux processes routinely have 0 bytes in SWAP, and=
 the
> only circumstances under which its processes can get into SWAP is after
> experiencing many SWAP-storms. It was so hard for the kernel to move thes=
e
> unused processes to SWAP that at some point I even tried to research if t=
here
> are any odd flags a userspace may have set on a process to keep it in RAM=
, just
> in case that's what happens to Skype (A: no, that wasn't the case, runnin=
g Skype
> in a memory limited cgroup makes it swap. It's just that kernel decision =
were
> lacking for some reason).
>
> So, anyway, I am delighted to see now that while testing this patchset, a=
nd
> without encountering even a single SWAP-storm yet, skypeforlinux are one =
of the
> processes residing in SWAP!!
>
>      =CE=BB smem -kc "name user pid pss swap" | grep skype
>     skypeforlinux            constantine  1151    60.0K     7.5M
>     skypeforlinux            constantine  1215   195.0K     8.1M
>     skypeforlinux            constantine  1149   706.0K     7.5M
>     skypeforlinux            constantine  1148   743.0K     7.3M
>     skypeforlinux            constantine  1307     1.4M     8.0M
>     skypeforlinux            constantine  1213     2.1M    46.1M
>     skypeforlinux            constantine  1206    14.0M    10.8M
>     skypeforlinux            constantine   818    38.5M    34.3M
>     skypeforlinux            constantine  1242   103.2M    46.8M
>
> !!!
>
> 1: https://kernelnewbies.org/Linux_5.12#Memory_management
>
> On Fri, 2021-04-30 at 02:46 +0300, Konstantin Kharlamov wrote:
> > In case you need it yet, this series is:
> >
> > Tested-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> >
> > My success story: I have Archlinux with 8G RAM + zswap + swap. While de=
veloping,
> > I have lots of apps opened such as multiple LSP-servers for different l=
angs,
> > chats, two browsers, etc=E2=80=A6 Usually, my system gets quickly to a =
point of SWAP-
> > storms, where I have to kill LSP-servers, restart browsers to free memo=
ry, etc,
> > otherwise the system lags heavily and is barely usable.
> >
> > 1.5 day ago I migrated from 5.11.15 kernel to 5.12 + the LRU patchset, =
and I
> > started up by opening lots of apps to create memory pressure, and worke=
d for a
> > day like this. Till now I had *not a single SWAP-storm*, and mind you I=
 got 3.4G
> > in SWAP. I was never getting to the point of 3G in SWAP before without =
a single
> > SWAP-storm.
> >
> > Right now my gf on Fedora 33 also suffers from SWAP-storms on her old M=
acbook
> > 2013 with 4G RAM + zswap + swap, I think the next week I'll build for h=
er 5.12 +
> > LRU patchset as well. Will see how it goes, I expect it will improve he=
r
> > experience by a lot too.
> >
> > P.S.: upon replying please keep me CCed, I'm not subscribed to the list
>