Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp643732pxy; Fri, 30 Apr 2021 13:06:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDyv5iJ41eF1UFaUKockmDMRulPQLMQdXK/VejmO+DTuZdWp8iEn3nMecqs05qY9hZIZMK X-Received: by 2002:a17:90a:390a:: with SMTP id y10mr4252272pjb.9.1619813204538; Fri, 30 Apr 2021 13:06:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619813204; cv=none; d=google.com; s=arc-20160816; b=t5UpECp04yV54cbQEdlx9Xa8ofFT6zPAowS4+PXKl0yRcWOS/bZBYU/Av3FzOSmjHN wLPpV25KJwlfmw3tr0N0oTy2OvalGTc+g2WpGLp5cDlZnhtj71Y+aMATeRcZ0x3cFzd3 gIiIN1TksPesGuE0eVpn5O53+Pi1LssxO/mlbzZdlzund3kjYk+oQZRQv+G102lswG5z fHSggX18WxstmA+WKBJeKgp78+XYa+bEl2K8CrpcffRBGGFkCygO6miLOlGNf0JA1MZk kzD4hxb2GkziO86uUEapUz1gw3orIFVw4XGCPGlaxbyOTA9phz4wEF9uT0UKV9wu5iH8 4zsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=T7ePI4bIX8CcnC5j3hUDE0qviNPb4HDFmqxhfLcKhzs=; b=O1Q+kCLtIWJeHbpEZuoy+gH7B1+HseHm5Ung3kPW9yAH7IEgUOKRj3Qm65bhXNcdW+ jG0CLNJGH8EFt+cDkNCK2Wd8gOlcY78DHo3BKffIGskI774wC15sGLyB/+dRtet2HWGl s3baHpwVM9L5JEDVVlkvsYTnSoLkAKLgaoGeoC1Mmm3sZNGKG2NuVfnApZ5dPzZ8knHh Qvbxtx9kIUK3p+oMB/aXwVWE9te6uIlCpohnAtadjght3rCa/Ig4/qURy7Ar8DpS+CVu b/0r86x2zS44a3k5AdveXmbNMLCMVNNf3qbRKAtat3ayKyJyqt610L8an2xu2SP5EGbD l/FA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si4301915pgq.426.2021.04.30.13.06.31; Fri, 30 Apr 2021 13:06:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235384AbhD3UGg (ORCPT + 99 others); Fri, 30 Apr 2021 16:06:36 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:36491 "EHLO mail-ot1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232957AbhD3UGe (ORCPT ); Fri, 30 Apr 2021 16:06:34 -0400 Received: by mail-ot1-f49.google.com with SMTP id n32-20020a9d1ea30000b02902a53d6ad4bdso10485975otn.3; Fri, 30 Apr 2021 13:05:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T7ePI4bIX8CcnC5j3hUDE0qviNPb4HDFmqxhfLcKhzs=; b=JYHPIFUIi4U/3CpgUtBQ7Rhnnyvk6THwNXM8+f97Y2NYapWSNgmEh+H63XzKdU6LI0 4ioATsTz4wZAxwb+dWpr83QvTcYE6iPvxWocro7exzBr2Grcn3p32XpFq1bSKNoAk2Om zgy9gfL2BXDnUygWqBY40kJ+Ip2jzntedgak9by5c+rhdGOrkD339nrX5xw5mlgZ8ADx kKabwfDeol4NC6ucynQvOX6/zxSISnxC4Rpp/c7N+TFhZ5qdvDUsf4egYmLGpgtf+h4X 1YBFHhAZAYRv8ubutJ1hoI5gWgcGuqdobsAVaXAbdhAuR+B72dwnBWH2E7fIIk0ehjDq yNvA== X-Gm-Message-State: AOAM530bD32PuAi/SZyxZAHmOxndWRy+rrd+zFUciCyzOIM547r/moWJ 4BkFgi3ZP4NsQAy+fGsJVA== X-Received: by 2002:a05:6830:30ad:: with SMTP id g13mr4929721ots.272.1619813144488; Fri, 30 Apr 2021 13:05:44 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id w3sm899112otg.78.2021.04.30.13.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 13:05:43 -0700 (PDT) Received: (nullmailer pid 3796857 invoked by uid 1000); Fri, 30 Apr 2021 20:05:42 -0000 Date: Fri, 30 Apr 2021 15:05:42 -0500 From: Rob Herring To: Bjorn Andersson Cc: Pavel Machek , Andy Gross , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Lee Jones , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Marijn Suijten , Yassine Oudjana , Luca Weiss , Subbaraman Narayanamurthy Subject: Re: [PATCH v7 1/6] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Message-ID: <20210430200542.GA3779966@robh.at.kernel.org> References: <20210429211517.312792-1-bjorn.andersson@linaro.org> <20210429211517.312792-2-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429211517.312792-2-bjorn.andersson@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 29, 2021 at 02:15:12PM -0700, Bjorn Andersson wrote: > This adds the binding document describing the three hardware blocks > related to the Light Pulse Generator found in a wide range of Qualcomm > PMICs. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v6: > - Backed qcom,dtest out of the child nodes again, as it's useful to be able to > route pwm signals through dtest lines as well (and pwm channels aren't > described as children). > - Added pm8150[bl] compatibles > - Dropped quotes around qcom,dtest > - Fixed indentation errors in subnode definition > > .../bindings/leds/leds-qcom-lpg.yaml | 158 ++++++++++++++++++ > 1 file changed, 158 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > new file mode 100644 > index 000000000000..2998598e8785 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > @@ -0,0 +1,158 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-qcom-lpg.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Light Pulse Generator > + > +maintainers: > + - Bjorn Andersson > + > +description: > > + The Qualcomm Light Pulse Generator consists of three different hardware blocks; > + a ramp generator with lookup table, the light pulse generator and a three > + channel current sink. These blocks are found in a wide range of Qualcomm PMICs. > + > +properties: > + compatible: > + enum: > + - qcom,pm8150b-lpg > + - qcom,pm8150l-lpg > + - qcom,pm8916-pwm > + - qcom,pm8941-lpg > + - qcom,pm8994-lpg > + - qcom,pmi8994-lpg > + - qcom,pmi8998-lpg > + > + "#pwm-cells": > + const: 2 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + qcom,power-source: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + power-source used to drive the output, as defined in the datasheet. > + Should be specified if the TRILED block is present constraints? > + > + qcom,dtest: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > > + A list of integer pairs, where each pair represent the dtest line the > + particular channel should be connected to and the flags denoting how the > + value should be outputed, as defined in the datasheet. The number of > + pairs should be the same as the number of channels. Sounds like a matrix rather than array. Constraints on the values? > + > + multi-led: > + type: object > + $ref: leds-class-multicolor.yaml# > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + "^led@[0-9a-f]$": > + type: object > + $ref: common.yaml# > + > +patternProperties: > + "^led@[0-9a-f]$": > + type: object > + $ref: common.yaml# > + > + properties: > + reg: true > + > + required: > + - reg > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + lpg { > + compatible = "qcom,pmi8994-lpg"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + qcom,power-source = <1>; > + > + qcom,dtest = <0 0 > + 0 0 > + 0 0 > + 4 1>; > + > + led@1 { > + reg = <1>; > + label = "green:user1"; > + }; > + > + led@2 { > + reg = <2>; > + label = "green:user0"; > + default-state = "on"; > + }; > + > + led@3 { > + reg = <3>; > + label = "green:user2"; > + }; > + > + led@4 { > + reg = <4>; > + label = "green:user3"; > + }; > + }; > + - | > + #include > + > + lpg { > + compatible = "qcom,pmi8994-lpg"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + qcom,power-source = <1>; > + > + multi-led { > + color = ; > + label = "rgb:notification"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <1>; > + color = ; > + }; > + > + led@2 { > + reg = <2>; > + color = ; > + }; > + > + led@3 { > + reg = <3>; > + color = ; > + }; > + }; > + }; > + - | > + lpg { > + compatible = "qcom,pm8916-pwm"; > + #pwm-cells = <2>; > + }; > +... > -- > 2.29.2 >