Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: abhinavk=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 30 Apr 2021 16:07:02 -0700
From:   abhinavk@codeaurora.org
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Kuogee Hsieh <khsieh@codeaurora.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        aravindh@codeaurora.org, freedreno@lists.freedesktop.org
Subject: Re: [Freedreno] [PATCH 0/6] drm/msm: Trim down drm debugging logs
In-Reply-To: <20210430193104.1770538-1-swboyd@chromium.org>
References: <20210430193104.1770538-1-swboyd@chromium.org>
Message-ID: <b11b19848701cd11cba5ee0d8befeeb8@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-04-30 12:30, Stephen Boyd wrote:
> This patch series attempts to trim down the drm logging in the msm
> driver to make it useable with DRM_UT_DRIVER, DRM_UT_KMS, and DRM_UT_DP
> levels enabled. Right now the log is really spammy and prints multiple
> lines for what feels like every frame. I moved those prints off to
> other DRM_UT_* levels that felt appropriate. Please review.
> 
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Abhinav Kumar <abhinavk@codeaurora.org>
> Cc: Kuogee Hsieh <khsieh@codeaurora.org>
> Cc: aravindh@codeaurora.org
> Cc: Sean Paul <sean@poorly.run>
> 
For the entire series,
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>

> Stephen Boyd (6):
>   drm/msm: Move vblank debug prints to drm_dbg_vbl()
>   drm/msm: Use VERB() for extra verbose logging
>   drm/msm/dp: Drop malformed debug print
>   drm/msm: Move FB debug prints to drm_dbg_state()
>   drm/msm/disp: Use plane debug print helper
>   drm/msm/disp: Move various debug logs to atomic bucket
> 
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c       |  2 +-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c  | 16 ++++----
>  drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 22 +++++------
>  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c      | 38 +++++++++----------
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   | 10 ++---
>  .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c  |  2 +-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c   |  6 +--
>  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c     | 19 ++++------
>  drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c      | 14 +++----
>  drivers/gpu/drm/msm/dp/dp_panel.c             |  1 -
>  drivers/gpu/drm/msm/msm_drv.c                 |  4 +-
>  drivers/gpu/drm/msm/msm_fb.c                  |  8 ++--
>  12 files changed, 67 insertions(+), 75 deletions(-)
> 
> 
> base-commit: 9f4ad9e425a1d3b6a34617b8ea226d56a119a717