Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <8e420732d2aabccca8b5e932b589ce90d9f70d6b.camel@gmail.com>
Subject: Re: [BUG] ethernet:enic: A use after free bug in
 enic_hard_start_xmit
From:   Govindarajulu Varadarajan <govind.varadar@gmail.com>
To:     lyl2019@mail.ustc.edu.cn, benve@cisco.com, davem@davemloft.net,
        kuba@kernel.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 30 Apr 2021 17:10:02 -0700
In-Reply-To: <65becad9.62766.17911406ff0.Coremail.lyl2019@mail.ustc.edu.cn>
References: <65becad9.62766.17911406ff0.Coremail.lyl2019@mail.ustc.edu.cn>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 2021-04-27 at 10:55 +0800, lyl2019@mail.ustc.edu.cn wrote:
> Hi, maintainers.
>     Our code analyzer reported a uaf bug, but it is a little
> difficult for me to fix it directly.
> 
> File: drivers/net/ethernet/cisco/enic/enic_main.c
> In enic_hard_start_xmit, it calls enic_queue_wq_skb(). Inside
> enic_queue_wq_skb, if some error happens, the skb will be freed
> by dev_kfree_skb(skb). But the freed skb is still used in 
> skb_tx_timestamp(skb).
> 
> ```
>         enic_queue_wq_skb(enic, wq, skb);// skb could freed here
> 
>         if (vnic_wq_desc_avail(wq) < MAX_SKB_FRAGS + ENIC_DESC_MAX_SPLITS)
>                 netif_tx_stop_queue(txq);
>         skb_tx_timestamp(skb); // freed skb is used here.
> ```
> Bug introduced by fb7516d42478e ("enic: add sw timestamp support").

Thank you for reporting this.

One solution is to make enic_queue_wq_skb() return error and goto spin_unlock()
incase of error.

Would you like to send the fix for this?

--
Govind