Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp910320pxy; Fri, 30 Apr 2021 21:04:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyC0o51O4WmgR5LYjIwyuvQ8WrMcYkkMA0I7EmP1dEC9na4TPcrAMFqGiE3RSRAJupPX4Vr X-Received: by 2002:a17:906:7842:: with SMTP id p2mr7755132ejm.87.1619841879574; Fri, 30 Apr 2021 21:04:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619841879; cv=none; d=google.com; s=arc-20160816; b=FElle0WutEhIZLN2FV0KqxKe+LUXdjI6CKEgQ2+W1PTdjCdlEygiqODsIYTnoPSjii X1m0ILyUymsm5dA1R8evgV98V5xppjPtZC0b8bHw+GNzj0FNlQ8QWk+vdm+UcBK3zLGS I/4bTFaZRu6wrWRBvnbOeQ504B3VPoIujqTQ4EiIZnO9Cj7ncrNqg59jpTceuNhQmjD3 7rhwNXS9qL660VH6dsOTCAvhRxBwlSe8JTbQnANaVddOHCEezg5SwoMNHocJb6cndG3p UswAJ8Z14dWZqEdOvWtpERFW1rUgc/0+ws7TgjW65Uno8Hx3vRSStw0XKUsXQsNdrAeQ xwzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9EWfN6Q5Rv8gB+tk1vfjKKN0pi0KFEkhCoeOlOL3DLI=; b=zj+2j1kSbcnyjRMWoKvNBJ9/t3tDdIUqn7fRsp3wf8YUiJ+pjday1sXDchMEodNDfH 2DiQ+Ofqvkzqjd2aON7ZfpXFQcn+okptAEYGAPel8X7NI8N2McjbC2GxIFBN20mGuJsZ 2xctTvjprLhQa9knOAAt8DCE382lVfWo7Omr4js3XPMnjw4SFqdSSWKBhd7najX5oD5g kkvWBQu1inxKq5sJXi6HHdDT7MTk2+nmLPwPYdMZsvivRk3KI5FX01Z5Cxir0Vlq2NYf ao785HD0W6Cl3QlUVESDoJ4p1OPH9mdl+xQd/fCk8qItJl74VY7uXeODE/jN5oDRYd6W /LxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eaXGRoeg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t2si3562977edy.589.2021.04.30.21.03.51; Fri, 30 Apr 2021 21:04:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eaXGRoeg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbhEADtk (ORCPT + 99 others); Fri, 30 Apr 2021 23:49:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbhEADtj (ORCPT ); Fri, 30 Apr 2021 23:49:39 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA414C06138B for ; Fri, 30 Apr 2021 20:48:50 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id y2so26962plr.5 for ; Fri, 30 Apr 2021 20:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9EWfN6Q5Rv8gB+tk1vfjKKN0pi0KFEkhCoeOlOL3DLI=; b=eaXGRoegD96gpKzZ+stodTichO/TnEvy4ynwE9EyvYqvGdRcrX7/MLAKgJciZsSTl/ 7AkVKrLVyWBJrTy3FRnFjJUOINEDvjzgTRs6F0+IJ1HmbAVy79Ch4uDXJCfSzc5+u2vz gyt2R60GJPXWOCOQ8gQmmv3bKGUDy/Y7xzCTE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9EWfN6Q5Rv8gB+tk1vfjKKN0pi0KFEkhCoeOlOL3DLI=; b=mHNjkU/eHyHn5iEEgRnDKobH3UpQNnWOiqii1n/Xqd4KqkoZJJAX96+US8PdLzD0c3 cXOpyTH/y+JczCdTBO3BcoZY0DtWgBcjxva0snu4gXQTaagmfAKMNY8zZbs0kb+6pw99 bSqrzCyr2zuwgpf4tg94Z5yCu1TPujc9TU8fhrBmDqEYFwe53Z4YLeY/QbiqhKYiBNvB EQMmUp9Pd/diGnQQizlU6fbcGvuKFELwCP2v8p0UC3Dw7fLa21hETw6ku99Abh1s3/rD XTZ7lL9mBiupPG/TE9lXHkWEmoP2evGa7FpR2cmbVtlUFOGWwYukzJgy1y3DOcWuTOI9 NWdA== X-Gm-Message-State: AOAM533mdTas3XyY0+2U6yN04flC7yn5y4To0Ju7c362p2R3W8twVQ9c T7XTPlF/yZ+EXrxMNZBPV/DpOA== X-Received: by 2002:a17:90a:f303:: with SMTP id ca3mr18382259pjb.145.1619840930197; Fri, 30 Apr 2021 20:48:50 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:8be7:e987:d00a:1442]) by smtp.gmail.com with ESMTPSA id a129sm3762621pfa.36.2021.04.30.20.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 20:48:49 -0700 (PDT) Date: Sat, 1 May 2021 12:48:45 +0900 From: Sergey Senozhatsky To: Hans Verkuil Cc: Tomasz Figa , Ricardo Ribalda , Christoph Hellwig , Mauro Carvalho Chehab , Sergey Senozhatsky , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 7/8] videobuf2: handle V4L2_MEMORY_FLAG_NON_COHERENT flag Message-ID: References: <20210427131344.139443-1-senozhatsky@chromium.org> <20210427131344.139443-8-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210427131344.139443-8-senozhatsky@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/04/27 22:13), Sergey Senozhatsky wrote: [..] > diff --git a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst > index e59306aba2b0..5a047c0ec3e8 100644 > --- a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst > +++ b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst > @@ -104,10 +104,14 @@ aborting or finishing any DMA in progress, an implicit > ``V4L2_MEMORY_MMAP`` and ``type`` set to the buffer type. This will > free any previously allocated buffers, so this is typically something > that will be done at the start of the application. > - * - __u32 > - - ``reserved``\ [1] > - - A place holder for future extensions. Drivers and applications > - must set the array to zero. > + * - __u8 > + - ``flags`` > + - Specifies additional buffer management attributes. > + See :ref:`memory-flags`. > + * - __u8 > + - ``reserved``\ [3] > + - Reserved for future extensions. > + - A fix (one liner). Sorry. --- Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst index 5a047c0ec3e8..099fa6695167 100644 --- a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst +++ b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst @@ -111,7 +111,6 @@ aborting or finishing any DMA in progress, an implicit * - __u8 - ``reserved``\ [3] - Reserved for future extensions. - - .. _v4l2-buf-capabilities: .. _V4L2-BUF-CAP-SUPPORTS-MMAP: -- 2.31.1.527.g47e6f16901-goog