Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1133882pxy; Sat, 1 May 2021 04:55:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCjpkanAoBTTGpb21r+BPVwaTmnKx83Ns6aVt74feVNxFJ1bS3mz9sAtXLZKLO8198r9TE X-Received: by 2002:a62:1a10:0:b029:28d:1590:d204 with SMTP id a16-20020a621a100000b029028d1590d204mr6291194pfa.78.1619870158550; Sat, 01 May 2021 04:55:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619870158; cv=none; d=google.com; s=arc-20160816; b=DZMCtcbSqbfKEEe0rSH4cv0CNJ0PGppGP7VHOnAVjSqwMXqCcnJgpvF67GhB7vwK3u GoGeKlGf4fErkhIxy2z36DLVCFRBQWR4Bv90NCyQEGWT4SOtfu+kZxBSP4EXj8W/U+I4 r3r6Ow+5dXe2AhqNzrHViuepvJbhGzOcEgPUgL01ZRTv7GURX0asDoIcqAKlKDOyq4K5 JNyR7tnCumoYee/rEu/uGYmGiLQ163as7InCsYVJsCW79Kzjh4KEU+9Aba6C5Q8I/0CF Dr+nrxwawzOHw+iGsejgVn0N5zHdcNenEvtlk44wT7TfHtXHsX5GdAEAOJp/xR9KoTCi oJQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=gf+xuHPwDKQvAS6eG8yHPFGOqttzS+hJ/YVhlgRyaQo=; b=ek45O4AGgK3TlFeY6UKYdhqmU9WcpnWaOKx5HA4Ki+UDeVxsdd1OriJYHltR1o7Jj/ /2JdTfTzBaQqDLdX8is2MAlkr7BHRK2Jp3j4WI3s8fptKLQEzGmRsbJIrxxTz0owLRBL f7I1t2dmR3c57ikzILOlKl5dfXJYaw+Lx5nBWRWSEOqZYGeTttDNBajo/jhI/e86aUoO b7Iic73h3rPM6THkkv6uOH0ExBId65k2fwi1aiOHHEDGewN3/UJIOl33rL2p4KGrzPO7 24TCKo8SuKrLvm4UJgJQZGAv4RXwizshvCobdwhdJlnb2VD9uMRSWs+OiDz6tFFZ3WbI iSig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 33si6945829plf.38.2021.05.01.04.55.45; Sat, 01 May 2021 04:55:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231979AbhEALws (ORCPT + 99 others); Sat, 1 May 2021 07:52:48 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:38119 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231960AbhEALws (ORCPT ); Sat, 1 May 2021 07:52:48 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d12 with ME id zPrv2400321Fzsu03PrvnW; Sat, 01 May 2021 13:51:57 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 01 May 2021 13:51:57 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch, heiko.stuebner@theobroma-systems.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] drm/panel: leadtek: Fix an error handling path Date: Sat, 1 May 2021 13:51:54 +0200 Message-Id: <588e8b4519487f6d33419c4b0fa7f8ea1b26cb58.1619869792.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'ret' is know to be >=0 a this point. Checking the return value of 'mipi_dsi_dcs_enter_sleep_mode()' was intended instead. So add the missing assignment. Fixes: 6ea4383b9214 ("drm/panel: add panel driver for Leadtek LTK050H3146W") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c index ed0d5f959037..6044703df1a7 100644 --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c @@ -450,7 +450,7 @@ static int ltk050h3146w_unprepare(struct drm_panel *panel) return ret; } - mipi_dsi_dcs_enter_sleep_mode(dsi); + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); if (ret < 0) { dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); return ret; -- 2.30.2