Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ashish <eashishkalra@gmail.com>
Date:   Sat, 1 May 2021 19:24:32 +0530
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Ashish Kalra <eashishkalra@gmail.com>,
        Ivan Safonov <insafonov@gmail.com>,
        Abheek Dhawan <adawesomeguy222@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Waiman Long <longman@redhat.com>,
        Pritthijit Nath <pritthijit.nath@icloud.com>,
        Allen Pais <apais@linux.microsoft.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument
 1 (different address spaces)
Message-ID: <YI1dmF0vDfH6lZHu@ashish-NUC8i5BEH>
References: <YI098DQNtK3i2Fge@ashish-NUC8i5BEH>
 <YI1IMG8tCvvRMq3i@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YI1IMG8tCvvRMq3i@kroah.com>
Precedence: bulk

On Sat, May 01, 2021 at 02:23:12PM +0200, Greg Kroah-Hartman wrote:
> On Sat, May 01, 2021 at 05:09:28PM +0530, Ashish Kalra wrote:
> > Currently p80211knetdev_do_ioctl use type casting to req->data to prevent sparse warning while calling memdup_user, instead of type casting it here, its better to change data type for data inside p80211ioctl_req to include __user.
> 
> Please properly line-wrap your changelog comments.
> 
> Can you fix it up and resend it as v3?
> 
> thanks,
> 
> greg k-h
Thanks Greg for your feedback
Kindly ignore v3 and review v4, i have modified it as pe your feedback