Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1239028pxy; Sat, 1 May 2021 07:42:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpzfk2Geicd6RCof/s8tWRPCb7QkFI3r2F8XqYoZs5IbwCvYX1Oa9zxtyCcbiBzbMA8hUx X-Received: by 2002:a63:ce07:: with SMTP id y7mr9765362pgf.293.1619880127163; Sat, 01 May 2021 07:42:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619880127; cv=none; d=google.com; s=arc-20160816; b=bVMEJ2RzGSKS2VIWGNt9NXIGKBdIvyWeh1jtrTVOfGsa4eqDuhrTAZbXAG5rezM+CG IvZXKiBtcUVfVPSYJgDVFl57GaXGfwbThitrgTu23MzsKZa+pftpT5y9qq5sLTwwNrSq 6vg/pUykZeyaZD+mr8sxYp/lzfVY6HZGlC/TodYLSzeZizWB1LzKyIIe4dtu5bbY2zXR uNjUyqdL9d560ZZgXcPCJi0BFajEn1U9Jfi7LJxSpu5A+qdhmCv8cXBRbxDgKiR0V6DQ MYzHaNjUF5ACb8FkRfpt2QCMTaoBWUdHwVETfT0EGqjsICGPe0i4IE/tiMlSvY3Vcl3A 0gPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=YnWb2IPj59++E0ETRcLd7/SnBjta6bFGoaxLShBdHqM=; b=I+9DxF/u4oyn22h6+2Bz7Ft4ncsNo1jRkFw4xXUiDy6ataaKzvPfQdoR+kA5BpsWtx Icvpyrl0hxilRl4ESGyhx0WM+oLDWvcwUZHsX6ZD0LWMfCLUXbsr7Og04ehyESd78SC0 Dcs/4pMO1svSqI7MnbHTUT0dxCDUynWRkTLCoJ+u4LuiAW+ki/yhupPLLC5JlCdJ3mnM PpVDn5GD4Nr7MXMRyc1vWdk7BqCtGGoT12Pu/l6Sl8JOTYXWWLOTWm//c+klnUPNHTgL QJitucPG+WMSzk20/6d6rRyE7CW0rmCzaK6AheK9D2K0CmY3J4lITBFRVgMYxz+pNalW 9VMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=es7+bN8w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z3si7040869pgb.216.2021.05.01.07.41.49; Sat, 01 May 2021 07:42:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=es7+bN8w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbhEAOmI (ORCPT + 99 others); Sat, 1 May 2021 10:42:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35288 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229979AbhEAOmH (ORCPT ); Sat, 1 May 2021 10:42:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619880077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YnWb2IPj59++E0ETRcLd7/SnBjta6bFGoaxLShBdHqM=; b=es7+bN8wlWsss+DV6DdLNbQ3LdELz8r8WrF6PTyasvD/zGAb2Co/faQgY6PSWwM1LgStpu lTCts/uIwJ/alStYBaRXyKMyKh92hEU9SapkxsqnWWioBV7K9oE8vYg4ctUOyq1w18Q+x4 UWhPnKufvcLHDOupmouHVNsLx0NFQ1E= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-kk3wWE0HPsCzf94gEYXoCg-1; Sat, 01 May 2021 10:41:15 -0400 X-MC-Unique: kk3wWE0HPsCzf94gEYXoCg-1 Received: by mail-io1-f69.google.com with SMTP id z25-20020a05660200d9b02903de90ff885fso574717ioe.11 for ; Sat, 01 May 2021 07:41:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YnWb2IPj59++E0ETRcLd7/SnBjta6bFGoaxLShBdHqM=; b=bf/OBpyvx6mHxXy5Sz5vuB17O6q/GDCYuDBRfq9AF98iD0qS67NMHazeTrvMteFpYY 8+hw9RceFvio+AbwGTsr0qq5RqNBO/4lCQ96KOMxHzD5zRsLRxmdAf2GE3KRAznV2x6F CO+4fLkJuiw9jeQ3+XNF1TopRCt6U9blCEfebKZEdC6zgrwW03qGw9fhybjLARpD2dQZ qLG82NxKKQwRLgC4tQheVJQg/dNia6KwH2I2wxobApRmGtoZHqO776UtQ+B21AdOroxl iEP5NW4/lWBm2zCXxaBJKaNx3f8UoWDcq7vn2OoJCHWl2a5zoLSr6N1wORG+GZdSsuz3 Sa1Q== X-Gm-Message-State: AOAM530R1aJRU1txeGMeBN2NbK88Cta78ze7NfeHd+7fVqZNPwm0xfbC DdN1nyHTSdhMQdx5Pmzf69/IAIsJAE46nmqHyPp/+d60v/DNqaUe68rYbtQcQVZLLyYRgHYBcGE xyTTWjbKscfM2PTLr5o25Sqv3 X-Received: by 2002:a5d:80d5:: with SMTP id h21mr7790083ior.11.1619880075174; Sat, 01 May 2021 07:41:15 -0700 (PDT) X-Received: by 2002:a5d:80d5:: with SMTP id h21mr7790067ior.11.1619880074946; Sat, 01 May 2021 07:41:14 -0700 (PDT) Received: from localhost.localdomain (bras-base-toroon474qw-grc-72-184-145-4-219.dsl.bell.ca. [184.145.4.219]) by smtp.gmail.com with ESMTPSA id k2sm2649343ilq.71.2021.05.01.07.41.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 May 2021 07:41:14 -0700 (PDT) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Hugh Dickins , Andrew Morton , Andrea Arcangeli , peterx@redhat.com, Mike Kravetz , Axel Rasmussen Subject: [PATCH 0/2] mm/hugetlb: Fix issues on file sealing and fork Date: Sat, 1 May 2021 10:41:08 -0400 Message-Id: <20210501144110.8784-1-peterx@redhat.com> X-Mailer: git-send-email 2.31.1 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hugh reported issue with F_SEAL_FUTURE_WRITE not applied correctly to=0D hugetlbfs, which I can easily verify using the memfd_test program, which se= ems=0D that the program is hardly run with hugetlbfs pages (as by default shmem).= =0D =0D Meanwhile I found another probably even more severe issue on that hugetlb f= ork=0D won't wr-protect child cow pages, so child can potentially write to parent= =0D private pages. Patch 2 addresses that.=0D =0D After this series applied, "memfd_test hugetlbfs" should start to pass.=0D =0D Please review, thanks.=0D =0D Peter Xu (2):=0D mm/hugetlb: Fix F_SEAL_FUTURE_WRITE=0D mm/hugetlb: Fix cow where page writtable in child=0D =0D fs/hugetlbfs/inode.c | 5 +++++=0D include/linux/mm.h | 32 ++++++++++++++++++++++++++++++++=0D mm/hugetlb.c | 2 ++=0D mm/shmem.c | 22 ++++------------------=0D 4 files changed, 43 insertions(+), 18 deletions(-)=0D =0D -- =0D 2.31.1=0D =0D