Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1595278pxy; Sat, 1 May 2021 19:24:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXZLOl8l0rvyCrPVBV9KhvE9YrbxGrfO87t0Bfm1o6nHABghEw2jTAaQeiAkTVuHgfcLV5 X-Received: by 2002:a63:5c4:: with SMTP id 187mr11950021pgf.304.1619922253379; Sat, 01 May 2021 19:24:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619922253; cv=none; d=google.com; s=arc-20160816; b=WETYkvYUDWwh2/sCy21Mj/kKOHwgPJ5rvvbLx4xs/dHEsFHPKA+LkOXiFVtcZzzBXS b9j99GdfPY563qOXt60NHm7ShvRQILr2xH/sxo+vHoDCOkc+k5QNzpEmHxSieg3FEWlc gJV4IPj+YTTMGsjsA+PE44LZwerKj/Mrs8ypWVQkxcM/ZMPWBotIwa1U4JljqqUYOS3e zuhlL89/l96HOGEuk7g1JkqQyR5UiT0OSu5bjBCS7Ccz+peP/VYwP7TuPEjO6e+mgy6y xcxI/+nOB+8xr4EWg+2trzv8NoXXj60ZqcfSH93NFZ06i+Q6vHmlMCFrWzaEaOxL7pZx iWcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=dqaSxBqnpQQ5yJej8q3aImwEDK5i+RDSkktLqxVmfqQ=; b=JINl4UN3XPkeFYsvE6Uf/t0/WoXqxf0O7eL4IUhFi+ZMPXEcTCNW6osJbsPdF5idCQ VI1TNnvXU8Ma7DfcFixecam91Wy+ZBSpnftLMr+XSFvP1AfBPd8orgLiy4FhM2Q72BIC HaZsllrimr49Io3Q4y4bDgnzxOXF/JYypdaeoSVelRSsHRhSHXJhLFwUHtDcDDKsaGi/ tfktYpQRvzf1N/iivx5PkMMo2BJZEzpKDZMJnF/jogG7UqM3THDlSrFii0jaApZ1eSWi 44K2LxGweX3CMqvfv0kwoz34/17HVqrJTJjrAToltdHIZh3LIzfcuxriD+d0LPSYKjZX ymEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vQK0rlGW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 10si8215643pfn.13.2021.05.01.19.23.39; Sat, 01 May 2021 19:24:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vQK0rlGW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231739AbhEBCSR (ORCPT + 99 others); Sat, 1 May 2021 22:18:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230409AbhEBCSR (ORCPT ); Sat, 1 May 2021 22:18:17 -0400 Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56571C06174A for ; Sat, 1 May 2021 19:17:26 -0700 (PDT) Received: by mail-vk1-xa2f.google.com with SMTP id u200so542727vku.3 for ; Sat, 01 May 2021 19:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dqaSxBqnpQQ5yJej8q3aImwEDK5i+RDSkktLqxVmfqQ=; b=vQK0rlGW8Dsa3qh1UIbGmJUu9RXzrm+isAmobNkeoTLYQI0QoPq2N8k7r9DyLI16TO BoRx9z6OpVHyirOZPr2aBrR0xB/L7+yTE0ZfMaLfjgqtSFoBe2ioMHLWpGH3fq9d503a OhYIoECfiHLIp6aK8TK9bFD6EWAxTncmA/ReZCz4JuBHipRwo9KMtUfc6+OG1hPiRHDD +Rvvkb7xZxVkc9QdbtazAuFTXbNvqBaZcX8lBecMbgNJOA9lCpN/7GdiUePgoJoPPo5F JwclkBpW78rlNgpSH+T59BmH1qaAmghr/EY+771j4uQw+80mhctanvGlJ0cZLCICXEMw WQ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqaSxBqnpQQ5yJej8q3aImwEDK5i+RDSkktLqxVmfqQ=; b=fi23c/YELOp/LKx/r7r9WgzPfDZ6jnV0xqrthSBeTUQmd/Om21o8amCYUpIgwuz5jI jeNo0P8Tw/k8xjV7RfHiQQo2F98UCC7lNTidjzn9XOg8nzKRABa2leI0BKyA77G7VudD HmMEmq9pyo5WI7VRW6Xk+X4q5fcVddoIKKhfPsViamO3L3rewLgXq7T28uhi4+dheipX ZINHXJouIRXgDr4S2/8T8XbTziQR5soLJQU5OuQzvM6btAg5wgRoMLV2Je46bjQilb1+ d4wsEF1yPE6ztIpIQHm+0Yti4zUvILXdokp1InN4nWQX9QLub5Pev/ow1LLZMT4pKGQ5 5pIw== X-Gm-Message-State: AOAM5305wm6O6QToQfCfjQan1jWmryHmjT/PospbQqrYAkN/xGENloXa V+BQzWkYsqRLct52PfcOitmQYjidH06LRX913NA= X-Received: by 2002:a1f:3a56:: with SMTP id h83mr11579567vka.10.1619921845348; Sat, 01 May 2021 19:17:25 -0700 (PDT) MIME-Version: 1.0 References: <20210316050801.2446401-1-jim.cromie@gmail.com> <87ft0rvl1r.fsf@linux.intel.com> In-Reply-To: <87ft0rvl1r.fsf@linux.intel.com> From: jim.cromie@gmail.com Date: Sat, 1 May 2021 20:16:59 -0600 Message-ID: Subject: Re: [RFC PATCH v3 00/18] dynamic debug diet plan To: Andi Kleen Cc: Jason Baron , Greg KH , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 18, 2021 at 10:12 PM Andi Kleen wrote: > > Jim Cromie writes: > > > CONFIG_DYNAMIC_DEBUG creates a struct _ddebug (56 bytes) for each > > callsite, which includes 3 pointers to: module, filename, function. > > These are repetetive, and compressible, this patch series goes about > > doing that, it: > > So how much memory does it actually save? > -Andi sorry for late reply, html mode got switched on and I didnt see kickback on my laptop/build, master has 165kb, about 70k is the compressible data, RLE column-wize could get close to 60% on my data. so ~40kb ? 3 things to do to get the savings: figure the compression, figure the hash holding enabled/used/expanded pr_debug decorations (maybe optional, depending on indexed/seek decompress time) drop the site pointer, with some anonymous union struct combo to blend header with callsites cleanly