Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210430062632.21304-1-heiko.thiery@gmail.com> <0daa2b24-e326-05d2-c219-8a7ade7376e0@gmail.com>
In-Reply-To: <0daa2b24-e326-05d2-c219-8a7ade7376e0@gmail.com>
From:   Heiko Thiery <heiko.thiery@gmail.com>
Date:   Sun, 2 May 2021 10:38:24 +0200
Message-ID: <CAEyMn7ZtziLf__KOGWJfY5OUDoaHSN8jopbKJeK9ZSD1NsZDjw@mail.gmail.com>
Subject: Re: [PATCH iproute2-next v2] lib/fs: fix issue when
 {name,open}_to_handle_at() is not implemented
To:     David Ahern <dsahern@gmail.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Stephen Hemminger <stephen@networkplumber.org>,
        Petr Vorel <petr.vorel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi David,

Am Sa., 1. Mai 2021 um 17:03 Uhr schrieb David Ahern <dsahern@gmail.com>:
>
> On 4/30/21 12:26 AM, Heiko Thiery wrote:
> > With commit d5e6ee0dac64b64e the usage of functions name_to_handle_at() and
>
> that is a change to ss:
>
> d5e6ee0dac64 ss: introduce cgroup2 cache and helper functions
>
>
> > open_by_handle_at() are introduced. But these function are not available
> > e.g. in uclibc-ng < 1.0.35. To have a backward compatibility check for the
> > availability in the configure script and in case of absence do a direct
> > syscall.
> >
>
> When you find the proper commit add a Fixes line before the Signed-off-by:

What do you mean with finding the right commit? This (d5e6ee0dac64) is
the commit that introduced the usage of the missing functions. Or have
I overlooked something?

>
> Fixes: <id> ("subject line")
> > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> > ---
>
> make sure you cc the author of the original commit.

Ok.

>
> > v2:
> >  - small correction to subject
> >  - removed IP_CONFIG_HANDLE_AT:=y option since it is not required
> >  - fix indentation in check function
> >  - removed empty lines (thanks to Petr Vorel)
> >  - add #define _GNU_SOURCE in check (thanks to Petr Vorel)
> >  - check only for name_to_handle_at (thanks to Peter Vorel)
>
> you have 3 responses to this commit. Please send an updated patch with
> all the changes and the the above comments addressed.

I will implement the comments and send a new version.

> Thanks,

Thanks,
-- 
Heiko