Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210423065327.1596075-1-hsinyi@chromium.org> <846d2a7a-d9c2-7d9e-9d7e-843ff604be44@collabora.com>
In-Reply-To: <846d2a7a-d9c2-7d9e-9d7e-843ff604be44@collabora.com>
From:   Hsin-Yi Wang <hsinyi@chromium.org>
Date:   Mon, 3 May 2021 13:06:13 +0800
Message-ID: <CAJMQK-iUzarwbvY3R-ezZWmZaDK58JzhEtzG+uyuZAJbsKmE1g@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: mt8183: add mediatek,gce-events in mutex
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 23, 2021 at 9:00 PM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Hsin-Yi,
>
> Thank you for your patch.
>
> On 23/4/21 8:53, Hsin-Yi Wang wrote:
> > mediatek,gce-events is read by mutex node.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>
> Although I know this property is used and needed I didn't find documentation
> about it. It would be really nice document in the bindings this mediatek property.
>
> In any case this patch LGTM, so
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>

I added the bindings in v2, thanks.

> > ---
> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index c5e822b6b77a..cf22d71161e5 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
> >                       reg = <0 0x14016000 0 0x1000>;
> >                       interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
> >                       power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> > +                     mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
> > +                                           <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
> >               };
> >
> >               larb0: larb@14017000 {
> >