Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp2472837pxy; Mon, 3 May 2021 00:14:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYB0pHOQ2yede5M+bhEnCc0Q6Pk9XdmfeZTOh1uFSoATqmIAHWDAhnYogBwtBKPYO0hD0o X-Received: by 2002:a62:1c0f:0:b029:25f:ba3c:9cc0 with SMTP id c15-20020a621c0f0000b029025fba3c9cc0mr17059943pfc.56.1620026055631; Mon, 03 May 2021 00:14:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620026055; cv=none; d=google.com; s=arc-20160816; b=lNzu1IucUKpnrENTrsre/kQcltdEzz1KyKejEdUGsJggnhNGNX31ofyas/hhxv9SCd VBsF82ltyHeo9CfOsFrnELgv3Rcl3rLAoIDln2hlg1Q077Ir2ajaLzK4dVGF5IXI0xZm mw7Rxg5xQH9I7X2uy0rtR4kX6A3i+6mwXo6xvc5A7QeZLsjXB+vT2uWY5pbJpNHzcyF8 qF7Li/icVPHZzsi50CE/d3Nyi+g3vDy0aiwA+xhfM9ibbdUaeForCwW8MjGR5FHAOwLN 6BneI5m6d7Gg67pz6TVKX7r54NteSDdYUOeSVjSwexDTQK0+wzts/ZyKLK5IC0oSehOu whhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=uTJf7qd34JeNQ/vDLzKx3qS2tBTitpAdK0TzACSggRA=; b=NcZLyhyIPhrbKJHKDEk9IvQq/LjZbn9MC7sJLSn54FP5HrdHqU+DxvjY3mExgI7LIb OpWo6YI+3IMY0SrWpwEGpHMjXQ+vhugPZ3ldJCqra7meF1PeUGZh6jb0We+GjjwxKWoC E4DqvEr+TvpX2WSe7e5cZQ0CiZofySrtTBvDSkvA1UfUEdzKpHvKWzWyeZlRUAKTh7tj /HiIXEdiBN91nHko9OYc7ofGuHOMSGAgiorfEu5/Z+KlgMWjO3+VH5Ov8EF59edVCy4I CXWMyrS24HKqxAbs+5mg/Eo4bciDVHLAvgkVbag+F8tyf1uAyblPcg7ouwlGQwzO51ow yVQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d10si13134174pgo.529.2021.05.03.00.14.01; Mon, 03 May 2021 00:14:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230490AbhECHNG (ORCPT + 99 others); Mon, 3 May 2021 03:13:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:54950 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbhECHNG (ORCPT ); Mon, 3 May 2021 03:13:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6DF41AFF0; Mon, 3 May 2021 07:12:12 +0000 (UTC) Date: Mon, 3 May 2021 09:12:04 +0200 From: Mian Yousaf Kaukab To: a.zummo@towertech.it, alexandre.belloni@bootlin.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, biwen.li@nxp.com Subject: Re: [PATCH v2] rtc: pcf2127: handle timestamp interrupts Message-ID: <20210503071204.GA31309@suse.de> References: <20210430091852.16444-1-ykaukab@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210430091852.16444-1-ykaukab@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 30, 2021 at 11:18:52AM +0200, Mian Yousaf Kaukab wrote: > commit 03623b4b041c ("rtc: pcf2127: add tamper detection support") > added support for timestamp interrupts. However they are not being > handled in the irq handler. If a timestamp interrupt occurs it > results in kernel disabling the interrupt and displaying the call > trace: > > [ 121.145580] irq 78: nobody cared (try booting with the "irqpoll" option) > ... > [ 121.238087] [<00000000c4d69393>] irq_default_primary_handler threaded [<000000000a90d25b>] pcf2127_rtc_irq [rtc_pcf2127] > [ 121.248971] Disabling IRQ #78 > > Handle timestamp interrupts in pcf2127_rtc_irq(). Set a flag to mark > the timestamp as valid and only report to sysfs if the flag is set. > > Signed-off-by: Mian Yousaf Kaukab > --- > history: > v2: -Add a flag to mark the occurrence of timestamp interrupt > -Add Biwen Li in Cc > > drivers/rtc/rtc-pcf2127.c | 53 +++++++++++++++++++++------------------ > 1 file changed, 28 insertions(+), 25 deletions(-) > > diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c > index d13c20a2adf7..0e2333ea1243 100644 > --- a/drivers/rtc/rtc-pcf2127.c > +++ b/drivers/rtc/rtc-pcf2127.c > @@ -94,10 +94,18 @@ > #define PCF2127_WD_VAL_MAX 255 > #define PCF2127_WD_VAL_DEFAULT 60 > > +/* Mask for currently enabled interrupts */ > +#define PCF2127_CTRL1_IRQ_MASK (PCF2127_BIT_CTRL1_TSF1) > +#define PCF2127_CTRL2_IRQ_MASK ( \ > + PCF2127_BIT_CTRL2_AF | \ > + PCF2127_BIT_CTRL2_WDTF | \ > + PCF2127_BIT_CTRL2_TSF2) > + > struct pcf2127 { > struct rtc_device *rtc; > struct watchdog_device wdd; > struct regmap *regmap; > + bool timestamp_valid; > }; > > /* > @@ -437,20 +445,33 @@ static int pcf2127_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) > static irqreturn_t pcf2127_rtc_irq(int irq, void *dev) > { > struct pcf2127 *pcf2127 = dev_get_drvdata(dev); > - unsigned int ctrl2 = 0; > + unsigned int ctrl1, ctrl2; > int ret = 0; > > + ret = regmap_read(pcf2127->regmap, PCF2127_REG_CTRL1, &ctrl1); > + if (ret) > + return IRQ_NONE; > + > ret = regmap_read(pcf2127->regmap, PCF2127_REG_CTRL2, &ctrl2); > if (ret) > return IRQ_NONE; > > - if (!(ctrl2 & PCF2127_BIT_CTRL2_AF)) > + if (!(ctrl1 & PCF2127_CTRL1_IRQ_MASK || ctrl2 & PCF2127_CTRL2_IRQ_MASK)) > return IRQ_NONE; > > - regmap_write(pcf2127->regmap, PCF2127_REG_CTRL2, > - ctrl2 & ~(PCF2127_BIT_CTRL2_AF | PCF2127_BIT_CTRL2_WDTF)); > + if (ctrl1 & PCF2127_CTRL1_IRQ_MASK) > + regmap_write(pcf2127->regmap, PCF2127_REG_CTRL1, > + ctrl1 & ~PCF2127_CTRL1_IRQ_MASK); > + > + if (ctrl2 & PCF2127_CTRL2_IRQ_MASK) > + regmap_write(pcf2127->regmap, PCF2127_REG_CTRL2, > + ctrl2 & ~PCF2127_CTRL2_IRQ_MASK); > > - rtc_update_irq(pcf2127->rtc, 1, RTC_IRQF | RTC_AF); > + if (ctrl1 & PCF2127_BIT_CTRL1_TSF1 || ctrl2 & PCF2127_BIT_CTRL2_TSF2) > + pcf2127->timestamp_valid = true; > + > + if (ctrl2 & PCF2127_BIT_CTRL2_AF) > + rtc_update_irq(pcf2127->rtc, 1, RTC_IRQF | RTC_AF); > > pcf2127_wdt_active_ping(&pcf2127->wdd); > > @@ -473,25 +494,8 @@ static ssize_t timestamp0_store(struct device *dev, > const char *buf, size_t count) > { > struct pcf2127 *pcf2127 = dev_get_drvdata(dev->parent); > - int ret; > > - ret = regmap_update_bits(pcf2127->regmap, PCF2127_REG_CTRL1, > - PCF2127_BIT_CTRL1_TSF1, 0); > - if (ret) { > - dev_err(dev, "%s: update ctrl1 ret=%d\n", __func__, ret); > - return ret; > - } > - > - ret = regmap_update_bits(pcf2127->regmap, PCF2127_REG_CTRL2, > - PCF2127_BIT_CTRL2_TSF2, 0); > - if (ret) { > - dev_err(dev, "%s: update ctrl2 ret=%d\n", __func__, ret); > - return ret; > - } > - > - ret = pcf2127_wdt_active_ping(&pcf2127->wdd); This call was removed by mistake. v3 already sent to restore it. > - if (ret) > - return ret; > + pcf2127->timestamp_valid = false; > > return count; > }; > @@ -524,8 +528,7 @@ static ssize_t timestamp0_show(struct device *dev, > if (ret) > return ret; > > - if (!(data[PCF2127_REG_CTRL1] & PCF2127_BIT_CTRL1_TSF1) && > - !(data[PCF2127_REG_CTRL2] & PCF2127_BIT_CTRL2_TSF2)) > + if (!pcf2127->timestamp_valid) > return 0; > > tm.tm_sec = bcd2bin(data[PCF2127_REG_TS_SC] & 0x7F); > -- > 2.26.2 BR, Yousaf