Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 3 May 2021 09:42:18 +0200
From:   Fabio Aiuto <fabioaiuto83@gmail.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/43] staging: rtl8723bs: remove if-else blocks left
 empty by ODM_RT_TRACE deletion
Message-ID: <20210503074217.GA1557@agape.jhs>
References: <cover.1619794331.git.fabioaiuto83@gmail.com>
 <0e1196ebf56787f62dcbfbcba1fcbc2ed37a65ce.1619794331.git.fabioaiuto83@gmail.com>
 <20210503072710.GL1981@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210503072710.GL1981@kadam>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Mon, May 03, 2021 at 10:27:11AM +0300, Dan Carpenter wrote:
> On Fri, Apr 30, 2021 at 04:56:24PM +0200, Fabio Aiuto wrote:
> > @@ -1533,13 +1529,10 @@ static void phy_IQCalibrate_8723B(
> >  				result[t][6] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> >  				result[t][7] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> >  				break;
> > -			} else {
> >  			}
> >  		}
> >  
> >  /* Allen end */
> 
> This comment doesn't mean anything.  It feels like it was supposed to
> go with the code that you deleted so it should have been deleted as part
> of deleting the empty block.  But it's fine to me if you delete it in
> a later patch.

Hi Dan,

ok I will.

> 
> > -		if (0x00 == PathBOK) {
> > -		}
> >  	}
> >  
> >  	/* Back to BB mode, load original value */
> 
> regards,
> dan carpenter
> 

thank you,

fabio