Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp2682752pxy; Mon, 3 May 2021 05:53:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz65Evkkq18dNXef2zHc158gl6SYdCX1E4MgC5YPRwe/V29umv5Zb/hQJPkyuEQdekgHQXI X-Received: by 2002:a65:558a:: with SMTP id j10mr17734060pgs.404.1620046380163; Mon, 03 May 2021 05:53:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620046380; cv=none; d=google.com; s=arc-20160816; b=wTX4gwhWWlCf/L5gKRyfVvQ/LI4/tdyH41bwjWqjMfppn0YOXTgqIIMub0E7D8bvd8 +sLHSVOUB97V3J3zUQ5lXVTORMwxjaXyMyZ41DTqK6fv0lgY3U4XRutrbuO6ps8b+RWn vMDd/naA/h08sD5LD4FGQNbQFfS6bCSBhynNLHzqTSnwqqQZpk1IBwpFxzhOfgJhwDyF 0yexMzEzhFQvB3DQurySaQdA2TLNvEhmOqXgamfhwbgchYnm7IAVrysA3RGMc0RTQkTu UQ83bcjBg+xdRVn04MwCX4+murjnOMW4ZRdGhEidZTIpm6bBo7S/ltOJLsmlSDkZyEut wJBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:reply-to:cc:from:to :dkim-signature:date; bh=wUfkSjCJnewhMEv3u15zjzGQMHZ9P3CYFHvLSQMnJkw=; b=ENaCNHIY//eEleyLUsvK/wcYrN1petEfv/pPUPnv11SGin7xF1GSoG5kECKR44+vjH 6Y/RbAAGqSz3VP8dCM8IeABY8UgT71ojYmqctbtzGgjgqNcmB2qjz2E7BXZBOTcRfYQN yWSgXdb2v1z+CjCt1+9X4dciUW1NxbZdoQ7xUgCMPtx4P+HgPO8xLXOPYJ9eJ+3myQjF gn4EduHltvzi2OBkZw3e2zEWfvVlhOqSQzRFsr4qc4cnQAwVAg9Y98Eh6AumGWGGkU2c B0UtvWGvp9VIFKqjuZbX4HX1y98UYsyjuUrw0+czHtcqpSMVvWVt2qXu2VrYIzlbG5dv eDcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=BVuu59Gw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c19si2201905pfo.31.2021.05.03.05.52.47; Mon, 03 May 2021 05:53:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=BVuu59Gw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233387AbhECLds (ORCPT + 99 others); Mon, 3 May 2021 07:33:48 -0400 Received: from mail-41104.protonmail.ch ([185.70.41.104]:29010 "EHLO mail-41104.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233269AbhECLdr (ORCPT ); Mon, 3 May 2021 07:33:47 -0400 Received: from mail-02.mail-europe.com (mail-0201.mail-europe.com [51.77.79.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail-41104.protonmail.ch (Postfix) with ESMTPS id 4FYgg447ZRz4x77Z for ; Mon, 3 May 2021 11:27:12 +0000 (UTC) Authentication-Results: mail-41104.protonmail.ch; dkim=pass (1024-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="BVuu59Gw" Date: Mon, 03 May 2021 11:27:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1620041228; bh=wUfkSjCJnewhMEv3u15zjzGQMHZ9P3CYFHvLSQMnJkw=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=BVuu59GwtJgSSJzN+XMCWUq0CxCwFnMgPFzhT9K6UtvFh2nzgZlfbyYI48Q9YQfDM iz42itRXoq/QyubyA+9NDW59wP7wAFSF3ZKN06G2EcxRLCbt/bT5lF43+rrb5B1oSi u+Exg1D/bwZQj0kfA1ldPcOBKAdINncwNXA03hUY= To: Greg Kroah-Hartman From: Jari Ruusu Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Jiri Kosina , Kalle Valo Reply-To: Jari Ruusu Subject: Re: [PATCH 5.10 1/2] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_gen2_enqueue_hcmd() Message-ID: In-Reply-To: References: <20210430141910.473289618@linuxfoundation.org> <20210430141910.521897363@linuxfoundation.org> <608CFF6A.4BC054A3@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, May 2, 2021 2:03 PM, Greg Kroah-Hartman wrote: > If you could provide backported patches to those kernels you think this > is needed to, I can take them directly. Otherwise running sed isn't > always the easiest thing to do on my end :) iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd() upstream commit 2800aadc18a64c96b051bcb7da8a7df7d505db3f, backport for linux-4.4.y (compile tested only) Signed-off-by: Jari Ruusu --- a/drivers/net/wireless/iwlwifi/pcie/tx.c +++ b/drivers/net/wireless/iwlwifi/pcie/tx.c @@ -1341,6 +1341,7 @@ static int iwl_pcie_enqueue_hcmd(struct iwl_trans *tr= ans, =09u32 cmd_pos; =09const u8 *cmddata[IWL_MAX_CMD_TBS_PER_TFD]; =09u16 cmdlen[IWL_MAX_CMD_TBS_PER_TFD]; +=09unsigned long flags2; =09if (WARN(!trans_pcie->wide_cmd_header && =09=09 group_id > IWL_ALWAYS_LONG_GROUP, @@ -1423,10 +1424,10 @@ static int iwl_pcie_enqueue_hcmd(struct iwl_trans *= trans, =09=09goto free_dup_buf; =09} -=09spin_lock_bh(&txq->lock); +=09spin_lock_irqsave(&txq->lock, flags2); =09if (iwl_queue_space(q) < ((cmd->flags & CMD_ASYNC) ? 2 : 1)) { -=09=09spin_unlock_bh(&txq->lock); +=09=09spin_unlock_irqrestore(&txq->lock, flags2); =09=09IWL_ERR(trans, "No space in command queue\n"); =09=09iwl_op_mode_cmd_queue_full(trans->op_mode); @@ -1588,7 +1589,7 @@ static int iwl_pcie_enqueue_hcmd(struct iwl_trans *tr= ans, =09spin_unlock_irqrestore(&trans_pcie->reg_lock, flags); out: -=09spin_unlock_bh(&txq->lock); +=09spin_unlock_irqrestore(&txq->lock, flags2); free_dup_buf: =09if (idx < 0) =09=09kfree(dup_buf); -- Jari Ruusu=C2=A0 4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD=C2=A0 ACDF F073 3C= 80 8132 F189