Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 3 May 2021 14:47:34 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Rijo Thomas <Rijo-john.Thomas@amd.com>
Cc:     Jens Wiklander <jens.wiklander@linaro.org>,
        Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
        Mythri Pandeshwara krishna <mythri.pandeshwarakrishna@amd.com>,
        op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] tee: amdtee: unload TA only when its refcount becomes
 0
Message-ID: <20210503114734.GI21598@kadam>
References: <5057c53afb568fa70234de2f23b0ffeff75af426.1618421014.git.Rijo-john.Thomas@amd.com>
 <5072c20c-7912-4307-6e04-caa1fe54bf1a@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5072c20c-7912-4307-6e04-caa1fe54bf1a@amd.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, May 03, 2021 at 09:04:35AM +0530, Rijo Thomas wrote:
> 
> 
> On 14/04/21 11:08 pm, Rijo Thomas wrote:
> > Same Trusted Application (TA) can be loaded in multiple TEE contexts.
> > 
> > If it is a single instance TA, the TA should not get unloaded from AMD
> > Secure Processor, while it is still in use in another TEE context.
> > 
> > Therefore reference count TA and unload it when the count becomes zero.
> > 
> > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> > Reviewed-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
> > Signed-off-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
> 
> Hi Dan,
> 
> Can you please give an Ack if you are okay with this patch.
> I have incorporated your review comments for v2.
> 

Oh, Sorry.  Thanks!

Acked-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter