Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp2719081pxy; Mon, 3 May 2021 06:36:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy38z2B/vZdzvbTbW0Bh+NNIzq1f2O/pH+z+6qyhUYMNq81mIgxeNGyvVewT15IaHDiR4i1 X-Received: by 2002:a17:902:a509:b029:ea:db56:e98 with SMTP id s9-20020a170902a509b02900eadb560e98mr20755804plq.65.1620048977651; Mon, 03 May 2021 06:36:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620048977; cv=none; d=google.com; s=arc-20160816; b=UE2ifcpp02XETRLf7/uL7ig8mSeIuvLFG+Y+hC8mvpCfJSqV0OVcYwGS8XWbu4igUD YsyUgTNuas/6EdFA0w9vRYulWGTsDWKNQoRjVE7dCa+b8q4vsrqfSqA3y83OHBFDGjoM d8Ak3fQtpM6gpBYadAA3W4zu7UchKaufjeHmsBB7uBwY2IkhbjIc4imYDCVeAs691GiQ DSKYrHfQuuGhvE/c2Ebnrpn433hHzi4hIud7DPVFFwclDh+iOyfC5Ihz4rlKF17Y2ppS E6ihlRwpW9fTA+lB5BjZK796efEe8M2BPHdgaxql1wDqzV+WW6woT5Gd5I1X/cvphdhy 63WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PS6uRpHhc4+toc9p0rOVYun0kr4UxosTgXBpiK1Ex70=; b=Plh+vIhLJn3KT3F0TFSSkcLnjKsMln8lMCgtGbiCMGm5lS0d7Sw+8Ul7K/5Im1mN5C u1Ph2vJfZmcj1pZvtKWTW4connCfo3MyzBHvdsH4SpEL0T6VGZEJ0x8QWkTEOh3eyrrD EkcBv4IcbDHc06pzTQtS5C4nvZ+DvvPtBsaBULX1ehDgGMKkFJ2Rg+j7dbJFp2Ie7A7k VcT0WFsOetX/n57IO0LW8LwRneL935kZacMLXx7tzuukckDFrOxi6A1JbNcMjThlJbcl lxlXWxjI4ioH2MuQiQ0G8FKshHB7cf93jVW8Fiq1oJo5TN+yr5EzisR/APGGA8GOvaJr EMsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MoA0NMxG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j9si16528751pgq.51.2021.05.03.06.36.05; Mon, 03 May 2021 06:36:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MoA0NMxG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233460AbhECMEi (ORCPT + 99 others); Mon, 3 May 2021 08:04:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:36862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234014AbhECMC2 (ORCPT ); Mon, 3 May 2021 08:02:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5CAA961077; Mon, 3 May 2021 12:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620043294; bh=UwR8hxuOP2LjMNeNYjtnGsV7B+45DJNQUCAyp8dcpXg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MoA0NMxGSD0gDa5YaisF+ipivuUk2Dr6G3gZ2550dpeyEQzxTewtZ5JtScqzgCZh6 1XQZWZ/NQ4gZASwM+i058RngjEZzB10BxugERid5kWt/9YiP8ZoquaLbJD7DEt9oOo RWv+OVz/5Pl4qtId/53ywLj0VWrOS7oIVfeMGD60= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Anirudh Rayabharam , Kalle Valo , Greg Kroah-Hartman Subject: [PATCH 43/69] ath6kl: return error code in ath6kl_wmi_set_roam_lrssi_cmd() Date: Mon, 3 May 2021 13:57:10 +0200 Message-Id: <20210503115736.2104747-44-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210503115736.2104747-1-gregkh@linuxfoundation.org> References: <20210503115736.2104747-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anirudh Rayabharam Propagate error code from failure of ath6kl_wmi_cmd_send() to the caller. Signed-off-by: Anirudh Rayabharam Cc: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath6kl/debug.c | 5 ++++- drivers/net/wireless/ath/ath6kl/wmi.c | 4 +--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c index 7506cea46f58..433a047f3747 100644 --- a/drivers/net/wireless/ath/ath6kl/debug.c +++ b/drivers/net/wireless/ath/ath6kl/debug.c @@ -1027,14 +1027,17 @@ static ssize_t ath6kl_lrssi_roam_write(struct file *file, { struct ath6kl *ar = file->private_data; unsigned long lrssi_roam_threshold; + int ret; if (kstrtoul_from_user(user_buf, count, 0, &lrssi_roam_threshold)) return -EINVAL; ar->lrssi_roam_threshold = lrssi_roam_threshold; - ath6kl_wmi_set_roam_lrssi_cmd(ar->wmi, ar->lrssi_roam_threshold); + ret = ath6kl_wmi_set_roam_lrssi_cmd(ar->wmi, ar->lrssi_roam_threshold); + if (ret) + return ret; return count; } diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index aca9732ec1ee..b137e7f34397 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -776,10 +776,8 @@ int ath6kl_wmi_set_roam_lrssi_cmd(struct wmi *wmi, u8 lrssi) cmd->info.params.roam_rssi_floor = DEF_LRSSI_ROAM_FLOOR; cmd->roam_ctrl = WMI_SET_LRSSI_SCAN_PARAMS; - ath6kl_wmi_cmd_send(wmi, 0, skb, WMI_SET_ROAM_CTRL_CMDID, + return ath6kl_wmi_cmd_send(wmi, 0, skb, WMI_SET_ROAM_CTRL_CMDID, NO_SYNC_WMIFLAG); - - return 0; } int ath6kl_wmi_force_roam_cmd(struct wmi *wmi, const u8 *bssid) -- 2.31.1