Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 03 May 2021 14:28:25 +0200
Message-ID: <s5h7dkgrogm.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org,
        Kurt Manucredo <fuzzybritches0@gmail.com>
Subject: Re: [PATCH 33/69] ALSA: gus: properly handle snd_ctl_add() error
In-Reply-To: <20210503115736.2104747-34-gregkh@linuxfoundation.org>
References: <20210503115736.2104747-1-gregkh@linuxfoundation.org>
        <20210503115736.2104747-34-gregkh@linuxfoundation.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 03 May 2021 13:57:00 +0200,
Greg Kroah-Hartman wrote:
> 
> From: Kurt Manucredo <fuzzybritches0@gmail.com>
> 
> snd_gus_init_control() does not properly return any possible error that
> might have happened in a call to snd_ctl_add() so resolve this by
> propagating the error back up the call change correctly.
> 
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Kurt Manucredo <fuzzybritches0@gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This change doesn't look good, either.
It results in the bogus error message "version check failed".

If we really want to fix this, it's better to call
snd_gus_init_control() from snd_gus_initialize() itself while changing
snd_gus_init_control() to return an error code.

However, this error is really not what we should be bothered too
much.  Even if a creation of control element failed, it's no fatal
error and nothing really wrong would happen by itself.  And, under
such a situation, the system memory is already too tight and the OS
would hang up sooner or later (or OOM killer starts genocide).


thanks,

Takashi

> ---
>  sound/isa/gus/gus_main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/isa/gus/gus_main.c b/sound/isa/gus/gus_main.c
> index b7518122a10d..4c2703ea55fb 100644
> --- a/sound/isa/gus/gus_main.c
> +++ b/sound/isa/gus/gus_main.c
> @@ -75,10 +75,11 @@ static const struct snd_kcontrol_new snd_gus_joystick_control = {
>  	.put = snd_gus_joystick_put
>  };
>  
> -static void snd_gus_init_control(struct snd_gus_card *gus)
> +static int snd_gus_init_control(struct snd_gus_card *gus)
>  {
>  	if (!gus->ace_flag)
> -		snd_ctl_add(gus->card, snd_ctl_new1(&snd_gus_joystick_control, gus));
> +		return snd_ctl_add(gus->card, snd_ctl_new1(&snd_gus_joystick_control, gus));
> +	return 0;
>  }
>  
>  /*
> @@ -386,8 +387,7 @@ static int snd_gus_check_version(struct snd_gus_card * gus)
>  	}
>  	strcpy(card->shortname, card->longname);
>  	gus->uart_enable = 1;	/* standard GUSes doesn't have midi uart trouble */
> -	snd_gus_init_control(gus);
> -	return 0;
> +	return snd_gus_init_control(gus);
>  }
>  
>  int snd_gus_initialize(struct snd_gus_card *gus)
> -- 
> 2.31.1
>