Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 3 May 2021 08:50:34 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     brookxu <brookxu.cn@gmail.com>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org,
        Dave Chinner <david@fromorbit.com>,
        Jens Axboe <jaxboe@fusionio.com>
Subject: Re: [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string
Message-ID: <20210503085034.0397fd54@gandalf.local.home>
In-Reply-To: <1619914347-21904-1-git-send-email-brookxu.cn@gmail.com>
References: <1619914347-21904-1-git-send-email-brookxu.cn@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk


This should go through the folks that maintain the write back trace events.

-- Steve


On Sun,  2 May 2021 08:12:27 +0800
brookxu <brookxu.cn@gmail.com> wrote:

> From: Chunguang Xu <brookxu@tencent.com>
> 
> Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a
> string is better.
> 
> v2: replace some space with tab.
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
> ---
>  include/trace/events/writeback.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 1efa463..7c78c04 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -36,7 +36,8 @@
>  	EM( WB_REASON_PERIODIC,			"periodic")		\
>  	EM( WB_REASON_LAPTOP_TIMER,		"laptop_timer")		\
>  	EM( WB_REASON_FS_FREE_SPACE,		"fs_free_space")	\
> -	EMe(WB_REASON_FORKER_THREAD,		"forker_thread")
> +	EM( WB_REASON_FORKER_THREAD,		"forker_thread")	\
> +	EMe(WB_REASON_FOREIGN_FLUSH,		"foreign_flush")
>  
>  WB_WORK_REASON
>