Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp2928801pxy; Mon, 3 May 2021 11:05:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFPyr0jWVQ7WAzf4II6wFGN3i4N15S/ejxqxfimVYNper/T6KpSXGwNkjzvzqiYa5FxFRW X-Received: by 2002:a17:90a:9284:: with SMTP id n4mr14425195pjo.35.1620065157126; Mon, 03 May 2021 11:05:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620065157; cv=none; d=google.com; s=arc-20160816; b=Y+RunEJSOeI9sQuTj+3tMpN2HvoVdbVMpH1fe+N1fhOkQD5/nC4fx+RmcDgXM/1lJf DAz+tz5J/VGYhLP/acWwgZqXw1EsQX3oYhZppzE+sbC24bWRP+gyy6auSmaIcA7bKn3P FLTR22k3Qfqyp6cPtkEN2gXkMLBUpiRaijgyrRUGCavuZjo8Y7a6r1PfXFZ0vSDlH8oL d1z+feAK5gt5783fwgDlbUe1Tzro1rKsiLqfUdqyKXjewXD0ycX+ifTiEgWeDJrsHF8i Ut7zy7lNtxTC94Q4kTFcXWhvIGEc2YyRlJS/V8Znfh9qX2gKdiAvEhW69+Cvwl4e4t/p Kl7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xkkVfn9TpT53mrvYYNcxvOEmriMUhwwVeXNf2+DjjRY=; b=jzPvS7tmi4A6bgK+PlV3cLDhKZZS/TNoMC662l/ZkUZ5ZB1OZLRWnWEaJNaI7Eg0Dc cuZqFnz/89QJEojfEBiBZ7CuAjepulVNv0pk5oa6cXsaloCCOOO+NNZ1u5nOBhr+ueF+ 4tnzY1P+FAVoVhZhgdyCoxwcesRMOoYWEbyE6/3buMzay+ngPvbLF9jEuFIIJG8eUG2d 7h3tMnOP5Unu4n6u77hb1J4ahOpQOkO3CScjDFP3sG/BU6hoNKMPdsRGe+ZGVe9qD53H hA/X7UCs7cZbH0PzL9Ln0glE8+b/YhgyOaDJ5jQBSokzWNDPvdc5Azj0B/9feCpVPFMV SZHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BcUXCQXo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w16si538798plg.24.2021.05.03.11.05.42; Mon, 03 May 2021 11:05:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BcUXCQXo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234055AbhECM4T (ORCPT + 99 others); Mon, 3 May 2021 08:56:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33933 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234009AbhECM4P (ORCPT ); Mon, 3 May 2021 08:56:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620046522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xkkVfn9TpT53mrvYYNcxvOEmriMUhwwVeXNf2+DjjRY=; b=BcUXCQXo3Wtf7zOWjv/kFLks6dHt2RWewiIYoCSnW5CJ5t28muRP2vB82Ha7wKAmJh3t6s dLvtAm0aXOmW/YdzZo/cKqfODowgYiQ15P4SvkEJoUUt2sP1UtFWiJx6EJlT6MGGzPcIBr KLgr/Ky+hyi+hjObNZl023QWMo7VS6Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-XgbUNEq-OFS03402vmyisQ-1; Mon, 03 May 2021 08:55:17 -0400 X-MC-Unique: XgbUNEq-OFS03402vmyisQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C69FA106B257; Mon, 3 May 2021 12:55:15 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E8D8756A4; Mon, 3 May 2021 12:55:11 +0000 (UTC) From: Maxim Levitsky To: kvm@vger.kernel.org Cc: Wanpeng Li , Thomas Gleixner , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), Jim Mattson , Vitaly Kuznetsov , Paolo Bonzini , "H. Peter Anvin" , Borislav Petkov , Joerg Roedel , Ingo Molnar , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), Sean Christopherson , Cathy Avery , Maxim Levitsky Subject: [PATCH 5/5] KVM: nSVM: set a dummy exit reason in L1 vmcb when loading the nested state Date: Mon, 3 May 2021 15:54:46 +0300 Message-Id: <20210503125446.1353307-6-mlevitsk@redhat.com> In-Reply-To: <20210503125446.1353307-1-mlevitsk@redhat.com> References: <20210503125446.1353307-1-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the nested migration is a result of a VMRUN, this makes it possible to keep a warning that L1 vmcb should always have VMRUN exit reason when switching back to it, which otherwise triggers incorrectly. Signed-off-by: Maxim Levitsky --- arch/x86/kvm/svm/nested.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index 12a12ae940fa..146be4b5084b 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -1338,6 +1338,12 @@ static int svm_set_nested_state(struct kvm_vcpu *vcpu, svm->vmcb01.ptr->save.rip = save->rip; svm->vmcb01.ptr->save.cpl = 0; + /* + * For consistency sake, restore the L1 exit reason + * (that happened prior to the migration) to SVM_EXIT_VMRUN. + */ + svm->vmcb->control.exit_code = SVM_EXIT_VMRUN; + nested_load_control_from_vmcb12(svm, ctl); svm_switch_vmcb(svm, &svm->nested.vmcb02); -- 2.26.2