Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp2932123pxy; Mon, 3 May 2021 11:09:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLWXD240Eft/PE4vs8478MvqVSHNDWbdEesKjfC4wv3o/jimSSJGO8xXfiOq9we9ZSdTxR X-Received: by 2002:a17:906:c099:: with SMTP id f25mr17731614ejz.499.1620065381280; Mon, 03 May 2021 11:09:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620065381; cv=none; d=google.com; s=arc-20160816; b=dQw/3VukuD91F+ivQMJMkMKgpTD/c+T+8QZtAvEktlb7PrDeRff9eNAHcNqylsTN/V amXftV3nX714tpesh18GGZBbIxk0MQXakAT10qF4uoWUuKLSx6dsRTpaNakmW4DmkO51 wXJU5AKooGLfPNaYHuJlu1p1keJxMRZuj94B+tx5ACaNmauEXXKFiN0fXvDellvkPKef 4PeY7fcM72RyoTCHAx070RYffuliJ2vYmne2i9ElRFLxDOlnathxBbFF7V62hfDuHBcs +GnKDZrqIvswjA5W1DYK5mjUxkTBYRMNRLu4FL9ItaeMeWq/nH4ar7JfjE3o5qlQZlUY DyCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0ymREoizmUlTzLTOubeXHNIpA0y2/Pio9TePzsQZRZc=; b=asXE5045mFVk98KiJKpCE5DYt5wJullw7nVWHX7Lq9IDDazDsqiHrGHYIMWgw9p98d Ua6wcrgGgVWnq+nl/cac6kDR44JcYIm5Z6J3rcclj2DVGI1CBGhPB12SUMGV9UpVqEuw cFZxevIwFTDX8ghhtB2EQcztoy6QMbD90XhLdVKD6JZA7ZTMewFvTUrUhrdS+Sqm5jlU 8P3oN/hdpcrc1hu+afrrUDKcBvfxrZWgKBvk4XpavwOt2rExmqb8ogB7bldZCltPNc7M wRSckDDmWLTbYtt6nkwGOststG7Uds4D88XzJ+RVXg/rCUAlmnDOFhGLNv7EohvWuLbL fh9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KnlyYhek; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si431400ejh.540.2021.05.03.11.09.16; Mon, 03 May 2021 11:09:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KnlyYhek; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234272AbhECNcd (ORCPT + 99 others); Mon, 3 May 2021 09:32:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:51104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233983AbhECNcc (ORCPT ); Mon, 3 May 2021 09:32:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F30FF61157; Mon, 3 May 2021 13:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620048698; bh=y0aNX63GrLtCzRF3/YYmoONu99cT979DYL0ElS2dVPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KnlyYhekri+ttWxM4G8NSYtpm8myivKAVX1qwx+2NdYqE/xLScN8U9tiBfixKXUMz UcIlqyOTbeH7kQuOzBIHbDZ6BIIbKW2J6WOnvEUw8TcXjsH2u1eb64i43seJRNllvi YSz8WAkrPhB5xmaRtUmSqN5jKtYBNrrvidgBZd9dC/yyVFhyeisShX3lvCjTBTZO9U PmkBQ0UKXmKueYUVXuD/ywoY5oW0sv0tsCjgMCI70AxreaPgJxrzqS3AnnqYLJLXzq za7fu5yqXIxKACwbNxlKSMlVLV8oCZv88OnWtZgtDA3XLeAgXGo9FrD/pAJNvv6/KS lkGSewnUNw7wA== Date: Mon, 3 May 2021 19:01:34 +0530 From: Vinod Koul To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Aditya Pakki , Sinan Kaya Subject: Re: [PATCH 50/69] Revert "dmaengine: qcom_hidma: Check for driver register failure" Message-ID: References: <20210503115736.2104747-1-gregkh@linuxfoundation.org> <20210503115736.2104747-51-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210503115736.2104747-51-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-05-21, 13:57, Greg Kroah-Hartman wrote: > This reverts commit a474b3f0428d6b02a538aa10b3c3b722751cb382. > > Because of recent interactions with developers from @umn.edu, all > commits from them have been recently re-reviewed to ensure if they were > correct or not. > > Upon review, this commit was found to be incorrect for the reasons > below, so it must be reverted. It will be fixed up "correctly" in a > later kernel change. > > The original change is NOT correct, as it does not correctly unwind from > the resources that was allocated before the call to > platform_driver_register(). Acked-By: Vinod Koul -- ~Vinod