Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v9] bio: limit bio max size
To:     Changheun Lee <nanich.lee@samsung.com>, axboe@kernel.dk,
        yi.zhang@redhat.com, ming.lei@redhat.com, bgoncalv@redhat.com,
        hch@lst.de, jaegeuk@kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, patchwork-bot@kernel.org
References: <CGME20210503101008epcas1p25d6b727dafcf9ff24db6aa41a3f611fa@epcas1p2.samsung.com>
 <20210503095203.29076-1-nanich.lee@samsung.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <72a0b4e7-a374-97fb-ae73-ed24f719da98@acm.org>
Date:   Mon, 3 May 2021 07:54:33 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <20210503095203.29076-1-nanich.lee@samsung.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/3/21 2:52 AM, Changheun Lee wrote:
>  struct queue_limits {
> +	unsigned int		bio_max_bytes;
> +
>  	enum blk_bounce		bounce;
>  	unsigned long		seg_boundary_mask;
>  	unsigned long		virt_boundary_mask;

On April 23 Damien Le Moal posted the following comment about the
bio_max_bytes member: "Please move this below in the structure together
with all other fields that are unsigned int too." Making that change
sounds like a good idea to me.

Thanks,

Bart.