Date: Fri, 20 Oct 2006 13:42:09 -0700 (PDT)
Message-Id: <20061020.134209.85688168.davem@davemloft.net>
To: shemminger@osdl.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] netpoll: rework skb transmit queue
From: David Miller <davem@davemloft.net>
In-Reply-To: <20061020084015.5c559326@localhost.localdomain>
References: <20061019171814.281988608@osdl.org>
	<20061020.001530.35664340.davem@davemloft.net>
	<20061020084015.5c559326@localhost.localdomain>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1678
Lines: 43

From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 20 Oct 2006 08:40:15 -0700

> -static void queue_process(void *p)
> +static void netpoll_run(unsigned long arg)
>  {
 ...
> -		spin_unlock_irqrestore(&queue_lock, flags);
> +		netif_tx_lock(dev);
> +		if (netif_queue_stopped(dev) ||
> +		    dev->hard_start_xmit(skb, dev) != NETDEV_TX_OK) {
> +			skb_queue_head(&npinfo->tx_q, skb);
> +			netif_tx_unlock(dev);
> +			tasklet_schedule(&npinfo->tx_task);
> +			return;
> +		}

We really can't handle TX stopped this way from the netpoll_send_skb()
path.  All that old retry logic in netpoll_send_skb() is really
necessary.

If we are in deep IRQ context, took an OOPS, and are trying to get a
netpoll packet out for the kernel log message, we have to try as hard
as possible to get the packet out then and there, even if that means
waiting some amount of time for netif_queue_stopped() to become false.

That is what the existing code is trying to do.

If you defer to a tasklet, the kernel state from the OOPS can be so
corrupted that the tasklet will never run and we'll never get the
netconsole message needed to debug the problem.

Also, if we tasklet schedule from the tasklet, we'll just keep looping
in the tasklet and never leave softirq context, which is also bad
behavior.  Even in the tasklet, we should spin and poll when possible
like the current netpoll_send_skb() code does.

So we really can't apply this patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/