Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp2933942pxy;
        Mon, 3 May 2021 11:11:39 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwjA3tvHeuiE9lf8/Gn7xjPDDEyRh8iq76gGvkTH1Nbh+Cy+qlxujJoR/n/9P6OeLqTEvBE
X-Received: by 2002:a17:907:1b20:: with SMTP id mp32mr18242775ejc.495.1620065499048;
        Mon, 03 May 2021 11:11:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1620065499; cv=none;
        d=google.com; s=arc-20160816;
        b=oZqmOXJyF+J2EvRwFqEgnRF0UCIOd1hWx5MNH5pAn2dmr9K9yGMZSWr04DLF791Xs5
         gaWb1ii3mf09TBJr3GIXeoWENCnA70v5ATwYnqqFyrdVs3Nt7h3HXxw1o/sIdyNEPWX7
         k7SrStjWyp51XbABbaE3rW6xG7yFlkYVs074/uR9nd4bkF7SQH1QbglFeP9czghRdsOL
         +27fFhjtIRR+20MLNxe33A+4znDZAkWPPNlo861jFnuJw0PaqJHL3puqppjFUo4XX7ir
         /qXnsV2rezx8De4G7Er9VCeJxn1lDxujX9T0dAUvWC2mNHUrRljiH4d16b9rGySnH+iP
         XhKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=X4LF+k6B/sVIUIEbam+HWbzqSMKCNUlcRKCT+EYaLRI=;
        b=HFmdOpdZMjP5PjKZZ8huoYgeR9D3MAcHELKjyFX1tuD2++3389ijt16ZqEbAp2av9v
         1BNU52WDq8t70AbhsTL4zhZbdTi/+zQCacEy7Euw9LaXD5xN6hLTM56xDJ1tnkiSe2yy
         7TVkiBEc66ZBM2ntqlVZYHR+yGcCl2x0TBedGYfEu1VUTBA696fr0XdkCqBnog3Wws48
         EqlsQ2RNw85HFeIX2232UpljkAYdhVdCmXzz44ohBaMDGq4l2qTwkrjSizf/sBhJG9E2
         XUPodERucX/dxEAjq1Ct2+sBAsOE3bj9huS8CeZ8sE3XeSy4njp82dPaZZZm88DAZ+gU
         2M6w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f51lklWq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a15si11296647edr.163.2021.05.03.11.11.15;
        Mon, 03 May 2021 11:11:39 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f51lklWq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230003AbhECO5K (ORCPT <rfc822;liuxingkeji@gmail.com>
        + 99 others); Mon, 3 May 2021 10:57:10 -0400
Received: from mail.kernel.org ([198.145.29.99]:60864 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229607AbhECO5I (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 May 2021 10:57:08 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id DAD15611BF;
        Mon,  3 May 2021 14:56:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1620053775;
        bh=xv32LexS87J6yWzpujvH+lIncd4ijHFRlcTNbaGV6S8=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=f51lklWqZBw5pbDwEr6wz8WtxE2rR5HXP7D7ZC7bsOUGjrTeX6p10jCekkHWYHgbL
         1ChKTZRulAlLPhIFDBVWiEHafpB9XJZwrNsRLWdTYayR8GwpWowHtnWOmMKv1MrKYo
         HbN/0EVgfsY4Rem9bLrX0UF8sHchpbs6Ur4EfoNXl9EdOv97WF2/iQfMhZEzDXQq+h
         4rC0ixTB6dd3cUNPafN5cjuxjrHkEZQIluTOuvryCSOWA/A9PMHIRehSJ8DCGKBxVA
         Ne2GNhNWTWTpjTdSf9raPyk8FDzARidkwi9tEYvG7eN769x95btOUAljITmPp5TP6H
         cVDB+KNXA1X0g==
Date:   Mon, 3 May 2021 17:56:12 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     trix@redhat.com
Cc:     jejb@linux.ibm.com, zohar@linux.ibm.com, dhowells@redhat.com,
        jmorris@namei.org, serge@hallyn.com,
        linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KEYS: trusted: fix memory leak
Message-ID: <YJAPDLo/FPIbdJR9@kernel.org>
References: <20210430185810.3331311-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210430185810.3331311-1-trix@redhat.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 30, 2021 at 11:58:10AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Static analysis reports this problem
> trusted-keys/trusted_tpm1.c:496:10: warning: Potential memory leak
>   return ret;
>          ^~~
> 
> In tpm_seal() some failure handling returns directly, without
> freeing memory.
> 
> Fixes: 5df16caada3f ("KEYS: trusted: Fix incorrect handling of tpm_get_random()")
> Signed-off-by: Tom Rix <trix@redhat.com>

Hi, thanks appreciate this but unfortunately applied Colin's fix already
:-/

/Jarkko