Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 3 May 2021 19:02:07 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     David Laight <David.Laight@aculab.com>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] eventfd: convert to using ->write_iter()
Message-ID: <20210503180207.GD1847222@casper.infradead.org>
References: <7b98e3c2-2d9f-002b-1da1-815d8522b594@kernel.dk>
 <de316af8f88947fabd1422b04df8a66e@AcuMS.aculab.com>
 <7caa3703-af14-2ff6-e409-77284da11e1f@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7caa3703-af14-2ff6-e409-77284da11e1f@kernel.dk>
Precedence: bulk

On Mon, May 03, 2021 at 11:57:08AM -0600, Jens Axboe wrote:
> On 5/3/21 10:12 AM, David Laight wrote:
> > From: Jens Axboe
> >> Sent: 03 May 2021 15:58
> >>
> >> Had a report on writing to eventfd with io_uring is slower than it
> >> should be, and it's the usual case of if a file type doesn't support
> >> ->write_iter(), then io_uring cannot rely on IOCB_NOWAIT being honored
> >> alongside O_NONBLOCK for whether or not this is a non-blocking write
> >> attempt. That means io_uring will punt the operation to an io thread,
> >> which will slow us down unnecessarily.
> >>
> >> Convert eventfd to using fops->write_iter() instead of fops->write().
> > 
> > Won't this have a measurable performance degradation on normal
> > code that does write(event_fd, &one, 4);
> 
> If ->write_iter() or ->read_iter() is much slower than the non-iov
> versions, then I think we have generic issues that should be solved.

We do!

https://lore.kernel.org/linux-fsdevel/20210107151125.GB5270@casper.infradead.org/
is one thread on it.  There have been others.

> That should not be a consideration, since the non-iov ones are
> legacy and should not be adopted in new code.
> 
> -- 
> Jens Axboe
>