Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-HdrOrdr: A9a23:UuRB3K4c3ftbjkInKwPXwbKBI+orLtY04lQ7vn1ZYxY9SKOlvu
 qpm+kW0gKxpTYKQXc7mc2BPq7oewK4ybde544NMbC+GDT8sGyzI414qafkyTvsGyrxn9QtsZ
 tIWa54FdH2EBxGnd/3iTPIceoI7dGb/MmT79v24GxqSWhRBp1IzwA8MQqDF10zeQ8uP+tfKL
 O5xu5q4wWtYm4WaMPTPAhnY8Hmq8fQnJzrJT4qbiRH1CC0gTml6KH3HnGjt390bxp1zbgv6m
 TDmQDij5/Cj9iA1hTe22XPhq45pPLdzLJ4aPCku4w8Nijrzj2lfp1mXKeP+Aooufi15Ewx+e
 O8xSsIDoBU927beH2zrF/L3QTtuQxek0PK+Bu/nWbpp9D/SXYBL/d5wahdchff9iMbzahB7J
 4=
Date:   Mon, 3 May 2021 11:06:54 -0700
From:   Daniel Walker <danielwa@cisco.com>
To:     Christophe Leroy <christophe.leroy@csgroup.eu>
Cc:     linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        xe-linux-external@cisco.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] lib: early_string: allow early usage of some string
 functions
Message-ID: <20210503180654.GP3844417@zorba>
References: <20210430042217.1198052-1-danielwa@cisco.com>
 <dc26a67e-dba0-1b8c-3718-3c75415c61f1@csgroup.eu>
 <1929b3a8-f882-c930-4b99-10c6a8f127c7@csgroup.eu>
 <e355ecc9-574a-dbcb-7864-5aa4974e1971@csgroup.eu>
 <20210503180141.GO3844417@zorba>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210503180141.GO3844417@zorba>
Precedence: bulk

On Mon, May 03, 2021 at 11:01:41AM -0700, Daniel Walker wrote:
> On Sat, May 01, 2021 at 09:31:47AM +0200, Christophe Leroy wrote:
> > 
> > > In fact, should be like in prom_init today:
> > > 
> > > #ifdef __EARLY_STRING_ENABLED
> > >  ????if (dsize >= count)
> > >  ??????? return count;
> > > #else
> > >  ????BUG_ON(dsize >= count);
> > > #endif
> > 
> > Thinking about it once more, this BUG_ON() is overkill and should be
> > avoided, see https://www.kernel.org/doc/html/latest/process/deprecated.html
> > 
> > Therefore, something like the following would make it:
> > 
> > 	if (dsize >= count) {
> > 		WARN_ON(!__is_defined(__EARLY_STRING_ENABLED));
> > 
> > 		return count;
> > 	}
> 
> I agree, it's overkill it stop the system for this condition.
> 
> how about I do something more like this for my changes,
> 
> 
> > 	if (WARN_ON(dsize >= count && !__is_defined(__EARLY_STRING_ENABLED)))
> > 		return count;

I'll have to work on this one..

Daniel