Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 3 May 2021 16:00:22 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Andi Kleen <ak@linux.intel.com>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf record: Set timestamp boundary for AUX area events
Message-ID: <YJBIRoRZ9WKvELQc@kernel.org>
References: <20210503064222.5319-1-adrian.hunter@intel.com>
 <20210503145637.GN4032392@tassilo.jf.intel.com>
 <fecadda6-b708-f7c8-ca9a-3521f168727e@intel.com>
 <20210503161131.GO4032392@tassilo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210503161131.GO4032392@tassilo.jf.intel.com>
Precedence: bulk

Em Mon, May 03, 2021 at 09:11:31AM -0700, Andi Kleen escreveu:
> On Mon, May 03, 2021 at 06:06:38PM +0300, Adrian Hunter wrote:
> > On 3/05/21 5:56 pm, Andi Kleen wrote:
> > > On Mon, May 03, 2021 at 09:42:22AM +0300, Adrian Hunter wrote:
> > >> AUX area data is not processed by 'perf record' and consequently the
> > >>  --timestamp-boundary option may result in no values for "time of first
> > >> sample" and "time of last sample". However there are non-sample events
> > >> that can be used instead, namely 'itrace_start' and 'aux'.
> > 
> > "instead" -> "as well"
> > 
> > >> 'itrace_start' is issued before tracing starts, and 'aux' is issued
> > >> every time data is ready.
> > > 
> > > Hmm, what happens when some other non PT events are in the same perf record?
> > 
> > The sample timestamps are still processed, so the lowest sample timestamp or
> > 'itrace_start' timestamp or 'aux' timestamp is the start.  Similarly for the end.
> > 
> > > And those maybe run at different times than PT (e.g. due to some PT specific
> > > filter).  Does this all work correctly then?
> > 
> > The broadest range is used
> 
> Ok makes sense.
> 
> Acked-by: Andi Kleen <ak@linux.intel.com>

Thanks, applied.

- Arnaldo