Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 3 May 2021 12:24:28 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     syzbot <syzbot+882a85c0c8ec4a3e2281@syzkaller.appspotmail.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        syzkaller-bugs@googlegroups.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org
Subject: Re: [syzbot] WARNING in do_proc_bulk
Message-Id: <20210503122428.30ebfddbaf8f5184dc73e1a7@linux-foundation.org>
In-Reply-To: <20210503185614.GA628313@rowland.harvard.edu>
References: <000000000000b47bc805c15e4b11@google.com>
        <00000000000000186405c16a6156@google.com>
        <20210503105351.0966275d0d9e001ed794de2c@linux-foundation.org>
        <20210503185614.GA628313@rowland.harvard.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 3 May 2021 14:56:14 -0400 Alan Stern <stern@rowland.harvard.edu> wrote:

> > 
> > do_proc_bulk() is asking kmalloc for more than MAX_ORDER bytes, in
> > 
> > 	tbuf = kmalloc(len1, GFP_KERNEL);
> 
> This doesn't seem to be a bug.  do_proc_bulk is simply trying to 
> allocate a kernel buffer for data passed to/from userspace.  If a user 
> wants too much space all at once, that's their problem.
> 
> As far as I know, the kmalloc API doesn't require the caller to filter 
> out requests for more the MAX_ORDER bytes.  Only to be prepared to 
> handle failures -- which do_proc_bulk is all set for.
> 
> Am I wrong about this?  Should we add __GFP_NOWARN to the gfp flags?

Yes, if the oversized request is a can-happen and the resulting error is handled
appropriately, __GFP_NOWARN is the way to go.