Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3044546pxy; Mon, 3 May 2021 13:50:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwA1MSPhebNHHx1Q+5qRtXEaiY+mjgibKGjZ8kUxonm8iS2n2k486pM96H39c3l02uJ4wg1 X-Received: by 2002:a05:6402:154d:: with SMTP id p13mr22552743edx.371.1620075010616; Mon, 03 May 2021 13:50:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620075010; cv=none; d=google.com; s=arc-20160816; b=n5ytWQIfmSkgFxVVn+VyhRLjNYZUnRn+ZPWMKZfy5djekMWtDKAaZTON1+0a2TKxjP gjA7tU4Fd3HIap+ITP5jtsTJjOGp4WaDOYFS5PPkfKAVgei3afOaKuKs7JrxZIXWHfD1 jJ2hCsni9Sog8j9I6TNgckrDhlUpVCdEQfL0uofn6HLcJFfJkRwdR2mBFFavdd3+AwFU kw6cj6r0W68HZkI5uzBqc+Qhb1uZj/nCzv3W1jhEnuf96DxiZwFkbrqD1rWBwmru20jx Q/RbF6wUULQ7B05KcdWmmnc9LwsrdV80ThIJcTH4M5AUec+b+Q38KNA+bEvG7zeqWeKr sKTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=x7u0BDPEHg/2DvRhSHGwyR9+XsE62DPr+9TRrCStF/A=; b=if8P17x3tHKaGXNVYqQD0muJadWj6Y8ugHITYyVFlsOB8xBsvlIwOt9Js8+Oq+xV59 WH7A9vfojMuHgJxfEuHCyMS8mh08y6bvrTZ8AVjzLQKxonzmUBB+ZdlyxD1SKelq2VOT 8lVvpYLC0Bqtxhn4hVxtkl4/P7jcycI8BViv4/VZ6qBkt7fNA9UvD+x6h36142LXCkHy j6jEWMWbw5rke0oouI35YjqNoejFllcYeTkWFq5Wj8gYO0eorAa0pNSijvzo6Vdwgu0E KsKuDwDW/HI4tFHZf4LGEuseBtRulCAlQKCkOsIClUSppoCxifIAuoded4/SlQBiQQY0 FoEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w11si1017898ejc.285.2021.05.03.13.49.47; Mon, 03 May 2021 13:50:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbhECUsR (ORCPT + 99 others); Mon, 3 May 2021 16:48:17 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46164 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229748AbhECUsQ (ORCPT ); Mon, 3 May 2021 16:48:16 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id E816A4D25963D; Mon, 3 May 2021 13:47:21 -0700 (PDT) Date: Mon, 03 May 2021 13:47:21 -0700 (PDT) Message-Id: <20210503.134721.2149322673805635760.davem@davemloft.net> To: lijunp213@gmail.com Cc: msuchanek@suse.de, netdev@vger.kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, drt@linux.ibm.com, sukadev@linux.ibm.com, tlfalcon@linux.ibm.com, kuba@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ibmvnic: remove default label from to_string switch From: David Miller In-Reply-To: References: <20210503102323.17804-1-msuchanek@suse.de> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Mon, 03 May 2021 13:47:22 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lijun Pan Date: Mon, 3 May 2021 13:21:00 -0500 > On Mon, May 3, 2021 at 5:54 AM Michal Suchanek wrote: >> >> This way the compiler warns when a new value is added to the enum but >> not the string transation like: > > s/transation/translation/ > > This trick works. > Since the original code does not generate gcc warnings/errors, should > this patch be sent to net-next as an improvement? Yes.