DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:Received:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=6i6W6ZxpHPikyc8NyKXxNQvVqVR2D8EdTSRjCS8Z1zXgBN1ruDfyu/MDInRBKGSd0fcsuyUNn6se8ip8O1kmr1mN/84PWdgW+6J588/z3hWYqkqs6ygI2AQA/m1cMbqiEQvhW5hNSvp20QGmvLl2CUtSNQaKcb5KPBsbnQC7MoQ=  ;
Message-ID: <20061020232711.54568.qmail@web55603.mail.re4.yahoo.com>
Date: Fri, 20 Oct 2006 16:27:10 -0700 (PDT)
From: Amit Choudhary <amit2030@yahoo.com>
Subject: Re: [PATCH 2.6.19-rc2] [REVISED 2] drivers/media/video/se401.c: check kmalloc() return value.
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <1161350098.26440.25.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 883
Lines: 23

> 
> If you know se401->sbuf[] and se401->scratch , urb etc are being cleared
> to NULL (or you did that) you could just use the kfree loops in nomem_
> for all cases as kfree(NULL) is an allowed "no-op"
> 
> 

In se401_stop_stream(), se401->sbuf[i].data is kfreed but not set to NULL. So, I could have
changed it there. But then I decided not to depend on anything else and do everything in
se401_start_stream(). But if this approach is wrong then please let me know.

Regards,
Amit

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/