Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3158528pxy; Mon, 3 May 2021 17:03:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeUNx42HNuKvZGIYH0+B5uapOJtFWN0kR/t132u4FJ5MCHp6nYauRMmLzn6AnGIau1QTeD X-Received: by 2002:aa7:d658:: with SMTP id v24mr22629965edr.290.1620086595062; Mon, 03 May 2021 17:03:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620086595; cv=none; d=google.com; s=arc-20160816; b=rbgBCNpfcx3mZewxYjMFd9y2P8ikWiyTBMeKh+nUfe7C9bOjwZ/g22bE1IiugujarF +2nc9XUR+2Alw1fXZuInCZU0zSJEy+5vJS98SGts/DG0Z3H3mToqD4lDVLmkANXaRDfe Jeq2yW03oVfwReIggW7AnsLgASBgDssm2foK0D50iqL0FmIB270va9JA/n9+TnfioO/A DgVZOuPQgMDjGSpHKWgL1bH9VIn8lT4JPhHoAY/FvCEPiuRcXMqBKxOPRFVuEA5rCg6I hvK9ik+IHLxA3aitLC5UXdYIsHbBY1BY4qVCV7eIyZnDY/AaD3o/l2cVOipoQD+H5NOP FMwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=RTrhwe5FlqMxAXLpGz6FP3pMNfP7DO0JlS/VtPEMG74=; b=LTQe5U2IGw2Jk+yooYvxy4cwfm2xHh3/ZICCNGfBTaGFDJwj7C4S926FQLv+iAwW74 YBcq7IPqIL/P7jnCDeDvy3j3+qEZHI8pogg8E+mSPmNa0KkXQhyRknAofAmB55F5Ilh2 JtK8i0Jfxc8FAvndM1hHN+GbiLSxR8c3B02NWO5oUI4GXDZKBdFbt/cd1+5JNxeesmP8 0TSNC3xzzXyzG7pnXX3lrBYb/QxiXlz0MsQADAc2/kMGhBikHNGySRbryy0oWvAP3hka B4fmwof7vbCEQVmD8Aw1u4ifr4wghcKVF76fRs8pairi1oqigdvufLqJ2anDM5aCtJEB Uvyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=OY1GqMrd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d21si1172721ejm.343.2021.05.03.17.02.50; Mon, 03 May 2021 17:03:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=OY1GqMrd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbhECX6L (ORCPT + 99 others); Mon, 3 May 2021 19:58:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhECX6L (ORCPT ); Mon, 3 May 2021 19:58:11 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A152C061574 for ; Mon, 3 May 2021 16:57:17 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id o127so174420wmo.4 for ; Mon, 03 May 2021 16:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=RTrhwe5FlqMxAXLpGz6FP3pMNfP7DO0JlS/VtPEMG74=; b=OY1GqMrdXwXrnAuXBTPr8YH2MPvErnn0sAltbHEyap7pDnJekaXQOqHbGBdfm0RmTC 6lrbrm1e8bB27RkTSrQwqflaQuijdIRWiTrYNSXGkdM5JCYyqZ4EcvpSTZlZQW/daRSE kvncir60eNNRthz++TvIxP8bZjVdylGQlR8cDFxgIfe/kgIjzRjgNUZNiZW6ZecvgUAB Q9fDdzkrWXVqblYfvjxyvNwuAiAWK/VqmVU2mInJer6EsufZ3Zj5yIMFZeMon7DiZvPh smhmClp5QXg53UJHwbbucyPhi5mj2VxExty0pJqxLAXoKTsjfnlHbBr+fvnRKTg6RJAk k20w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=RTrhwe5FlqMxAXLpGz6FP3pMNfP7DO0JlS/VtPEMG74=; b=GKC17IWmj4q5vpAgUqno++IeYEsfw4EhAv1lHTkS+rWe0cDErwe7768n0XEZfSrGBS qa0Vr7xp3Cm6CZ++jO85Tg2BBOQTGJra2keAQRVyKHgqRzI7dhREahKA9Loll4V/QJ85 SIYIARzdW9VibpJKxn33KO6xrtNPwEv/oHhSeTSjRku2Crtx+xdtAj8Jfv4CA1Rgfu7M 5Ub0aalf/suNMI8fpckpBMn1Mc1F7QcOtGfqUA7JHG1bSeyDXEV0dxnZD62QIUxktYio S4Ivla0xBn+XNQE7dNaJQk2NRoajlhjn66RtTmsev/ZJf3wtpVuOdW/r1I0TL7PqnSJV /GxQ== X-Gm-Message-State: AOAM5302m2C2ip15Zgr6q3yOpMa9Ra7A2WKkJfbL4O8I4ChAR45DEZ3U o1KhDVoT3bO058ZqpBQc6JES/w== X-Received: by 2002:a05:600c:3388:: with SMTP id o8mr1025054wmp.101.1620086235839; Mon, 03 May 2021 16:57:15 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id l14sm14048582wrv.94.2021.05.03.16.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 16:57:15 -0700 (PDT) From: Kevin Hilman To: Martin Blumenstingl , narmstrong@baylibre.com, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Martin Blumenstingl , Stefan Agner Subject: Re: [PATCH RFC] soc: amlogic: meson-ee-pwrc: Drop the .shutdown callback from the driver In-Reply-To: <20210429203723.1177082-1-martin.blumenstingl@googlemail.com> References: <20210429203723.1177082-1-martin.blumenstingl@googlemail.com> Date: Mon, 03 May 2021 16:57:12 -0700 Message-ID: <7h4kfjpe07.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Martin Blumenstingl writes: > Stefan reports that rebooting his ODROID-N2+ (using a G12B SoC) results > in the board hanging. His kernel config uses: > CONFIG_MESON_EE_PM_DOMAINS=y > CONFIG_DRM_MESON=m > > He reports that his kernel config results in the DRM driver's .shutdown > callback to be executed after the power domain driver's .shutdown > callback. That's problematic because meson_ee_pwrc_shutdown disables the > clock which are used by the VPU IP. This causes the board to hang. I didn't dig deeply on this yet because this smells very much like an issue Art reported[1] and fixed. What kernel version are you using, and does it contain commit fa0c16caf3d7 (drm: meson_drv add shutdown function) Kevin [1] https://lore.kernel.org/dri-devel/20210302042202.3728113-1-art@khadas.com/