Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Alexandru Ardelean <aardelean@deviqon.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "jic23@kernel.org" <jic23@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Paul Cercueil <paul@crapouillou.net>
Subject: RE: [PATCH] iio: core: return ENODEV if ioctl is unknown
Thread-Topic: [PATCH] iio: core: return ENODEV if ioctl is unknown
Thread-Index: AQHXQCrCxfTLsNo77UuEgqa1zoIhb6rS6BuQ
Date:   Tue, 4 May 2021 07:10:19 +0000
Message-ID: <PH0PR03MB6366BD5B07B0E42FD436774B995A9@PH0PR03MB6366.namprd03.prod.outlook.com>
References: <20210503144350.7496-1-aardelean@deviqon.com>
In-Reply-To: <20210503144350.7496-1-aardelean@deviqon.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b8352e3-79cf-4289-d475-08d90ecbad18
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2021 07:10:19.3517
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cOq+w/KvP7h1eNuHDwEguz4BnprFL21B/rfzzVFTLVCarjBc2WGd+yONe3DWmnUFtzGrV4F8FaLeOxaf5U66Pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5765
X-Proofpoint-ORIG-GUID: b9UTAdaCSmx5GYpGNUcov_kQ7RRfmfjt
X-Proofpoint-GUID: b9UTAdaCSmx5GYpGNUcov_kQ7RRfmfjt
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-05-04_02:2021-05-03,2021-05-04 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 mlxlogscore=999 priorityscore=1501 impostorscore=0 adultscore=0 mlxscore=0
 suspectscore=0 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2105040052
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Alexandru Ardelean <aardelean@deviqon.com>
> Sent: Monday, May 3, 2021 4:44 PM
> To: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: jic23@kernel.org; lars@metafoo.de; Alexandru Ardelean
> <aardelean@deviqon.com>; Linus Walleij <linus.walleij@linaro.org>;
> Paul Cercueil <paul@crapouillou.net>; Sa, Nuno
> <Nuno.Sa@analog.com>
> Subject: [PATCH] iio: core: return ENODEV if ioctl is unknown
> =20
> When the ioctl() mechanism was introduced in IIO core to centralize
> the
> registration of all ioctls in one place via commit 8dedcc3eee3ac ("iio:
> core: centralize ioctl() calls to the main chardev"), the return code was
> changed from ENODEV to EINVAL, when the ioctl code isn't known.
>=20
> This was done by accident.
>=20
> This change reverts back to the old behavior, where if the ioctl() code
> isn't known, ENODEV is returned (vs EINVAL).
>=20
> This was brought into perspective by this patch:
>   https://urldefense.com/v3/__https://lore.kernel.org/linux-
> iio/20210428150815.136150-1-
> paul@crapouillou.net/__;!!A3Ni8CS0y2Y!rbiZhkgdYhOPdii_YEAgO0BlX
> UxYANj3juvQuoWtaH61DSon2xK5i_BRar5Jyw$
>=20
> Fixes: 8dedcc3eee3ac ("iio: core: centralize ioctl() calls to the main
> chardev")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Paul Cercueil <paul@crapouillou.net>
> Cc: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---

Reviewed-by: Nuno S=E1 <nuno.sa@analog.com>

>  drivers/iio/industrialio-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-
> core.c
> index efb4cf91c9e4..9a3a83211a90 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -1803,7 +1803,6 @@ static long iio_ioctl(struct file *filp, unsigned
> int cmd, unsigned long arg)
>  	if (!indio_dev->info)
>  		goto out_unlock;
>=20
> -	ret =3D -EINVAL;
>  	list_for_each_entry(h, &iio_dev_opaque->ioctl_handlers,
> entry) {
>  		ret =3D h->ioctl(indio_dev, filp, cmd, arg);
>  		if (ret !=3D IIO_IOCTL_UNHANDLED)
> @@ -1811,7 +1810,7 @@ static long iio_ioctl(struct file *filp, unsigned
> int cmd, unsigned long arg)
>  	}
>=20
>  	if (ret =3D=3D IIO_IOCTL_UNHANDLED)
> -		ret =3D -EINVAL;
> +		ret =3D -ENODEV;
>=20
>  out_unlock:
>  	mutex_unlock(&iio_dev_opaque->info_exist_lock);
> --
> 2.31.1

- Nuno S=E1