Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Barry Song <song.bao.hua@hisilicon.com>, peterz@infradead.org,
        corbet@lwn.net
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, Barry Song <song.bao.hua@hisilicon.com>
Subject: Re: [PATCH] Documentation: scheduler: sched_debug_verbose cmdline should be sched_verbose
In-Reply-To: <20210504105344.31344-1-song.bao.hua@hisilicon.com>
References: <20210504105344.31344-1-song.bao.hua@hisilicon.com>
Date:   Tue, 04 May 2021 12:09:24 +0100
Message-ID: <87h7jiycuz.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 04/05/21 22:53, Barry Song wrote:
> The cmdline should include sched_verbose but not sched_debug_verbose
> as sched_debug_verbose is only the variant name in code.
>
> Fixes: 9406415f46 ("sched/debug: Rename the sched_debug parameter to sched_verbose")
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>

Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>

> ---
>  Documentation/scheduler/sched-domains.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/scheduler/sched-domains.rst b/Documentation/scheduler/sched-domains.rst
> index 14ea2f2..84dcdcd 100644
> --- a/Documentation/scheduler/sched-domains.rst
> +++ b/Documentation/scheduler/sched-domains.rst
> @@ -74,7 +74,7 @@ for a given topology level by creating a sched_domain_topology_level array and
>  calling set_sched_topology() with this array as the parameter.
>
>  The sched-domains debugging infrastructure can be enabled by enabling
> -CONFIG_SCHED_DEBUG and adding 'sched_debug_verbose' to your cmdline. If you
> +CONFIG_SCHED_DEBUG and adding 'sched_verbose' to your cmdline. If you
>  forgot to tweak your cmdline, you can also flip the
>  /sys/kernel/debug/sched/verbose knob. This enables an error checking parse of
>  the sched domains which should catch most possible errors (described above). It
> --
> 1.8.3.1